-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix broken env fuzzer by initializing process #51080
Conversation
105a7cf
to
5f55806
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I do wonder why this is not using node::InitializeOncePerProcess()
instead..
Actually I just noticed that it seems the fuzzers aren't tearing down the platform etc. properly. See node/test/cctest/node_test_fixture.cc Lines 36 to 43 in b68fa59
|
Thank you for the feedback. I will test this and make a follow-up PR. |
Signed-off-by: Adam Korczynski <adam@adalogics.com>
Landed in d9b61db |
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: nodejs#51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: nodejs#51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Fixes a broken fuzzer.
It looks like the fuzzer is leaking memory, but it is so slow that it is hard to tell. Once the fuzzer starts running on OSS-Fuzz again, we should get good feedback. If it has a leak, then I plan to fix it over the next couple of weeks; If anyone can spot a possible leak without running it, it would be a great help.