-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watch: fix infinite loop when passing --watch=true flag #51160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
labels
Dec 14, 2023
pulkit-30
changed the title
test_runner: fix infinite loop when passing --watch=true flag
fs_watch: fix infinite loop when passing --watch=true flag
Dec 15, 2023
pulkit-30
changed the title
fs_watch: fix infinite loop when passing --watch=true flag
watch: fix infinite loop when passing --watch=true flag
Dec 15, 2023
MoLow
approved these changes
Dec 15, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 15, 2023
marco-ippolito
approved these changes
Dec 15, 2023
debadree25
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 15, 2023
debadree25
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 16, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 16, 2023
Landed in 154afbe |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #51159
code:
run with cmd:
./node --watch=true index.mjs
before:
now:
Note: watch-mode will be activated with
--watch=false
flag as well