Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permission: fix wildcard when children > 1 #51209

Merged
merged 1 commit into from
Dec 21, 2023
Merged

permission: fix wildcard when children > 1 #51209

merged 1 commit into from
Dec 21, 2023

Conversation

RafaelGSS
Copy link
Member

Fixes: #50659

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label Dec 18, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 18, 2023
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56375/

@RafaelGSS RafaelGSS force-pushed the handle-wildcard-with-children-pm branch from b417898 to d833469 Compare December 19, 2023 19:34
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56398/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56431/

ShogunPanda
ShogunPanda approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3f2e234 into nodejs:main Dec 21, 2023
54 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3f2e234

RafaelGSS added a commit that referenced this pull request Jan 2, 2024
@RafaelGSS
permission: fix wildcard when children > 1
8f4325d 
PR-URL: #51209
Fixes: #50659
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
RafaelGSS added a commit that referenced this pull request Feb 14, 2024
@RafaelGSS
test,doc: clarify wildcard usage
834ae37 
Follow-up: #51209
PR-URL: nodejs-private/node-private#517
Fixes: https://hackerone.com/bugs?subject=nodejs&report_id=2257156
CVE-ID: CVE-2024-21890
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 20, 2024
@RafaelGSS @rdw-msft
test,doc: clarify wildcard usage
370fa78 
Follow-up: nodejs#51209
PR-URL: https://github.com/nodejs-private/node-private/pull/517
Fixes: https://hackerone.com/bugs?subject=nodejs&report_id=2257156
CVE-ID: CVE-2024-21890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@Qard Qard Qard approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experimental permission wildcards seem to not be additive
5 participants
@RafaelGSS @nodejs-github-bot @ShogunPanda @Qard @Trott