-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fixup alignment of warning subsection #51374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
process
Issues and PRs related to the process subsystem.
labels
Jan 4, 2024
lpinca
approved these changes
Jan 4, 2024
Subsection was accidentally aligned with the wrong event.
jasnell
force-pushed
the
docs-fixup-warning
branch
from
January 4, 2024 19:52
b253482
to
46ee891
Compare
jasnell
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Jan 4, 2024
Fast-track has been requested by @jasnell. Please 👍 to approve. |
marco-ippolito
approved these changes
Jan 4, 2024
KhafraDev
approved these changes
Jan 4, 2024
bnb
approved these changes
Jan 5, 2024
HarshithaKP
approved these changes
Jan 5, 2024
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 5, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 5, 2024
Landed in 41df252 |
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 12, 2024
Subsection was accidentally aligned with the wrong event. PR-URL: nodejs#51374 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
Subsection was accidentally aligned with the wrong event. PR-URL: nodejs#51374 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
Subsection was accidentally aligned with the wrong event. PR-URL: #51374 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Subsection was accidentally aligned with the wrong event. PR-URL: #51374 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Subsection was accidentally aligned with the wrong event. PR-URL: #51374 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
process
Issues and PRs related to the process subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsection was accidentally aligned with the wrong event.