benchmark: update iterations of benchmark/async_hooks/async-local- #51420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
|
benchmark@benchmark-S2600WFT: v16.20.2/bin/node benchmark/async_hooks/async-local-storage-getstore-nested-resources.js compared with node16, node21 performance downgraded by about 40%. Root cause is repetition is too small and only occupies about 1% of scoring period while 99% is occupied by GC. When the repetition is enlarged a lot, node21 downgration was fixed. |
legendecas
approved these changes
Mar 1, 2024
|
Would you mind rebasing on top of the main branch? One of the GitHub actions failed but I can not restart it. |
|
sure I will rebase |
storage-getstore-nested-resources.js Fixes: nodejs#50571
lucshi
force-pushed
the
async_hooks/async-local-storage-getstore-nested-resources.js
branch
from
5156af6 to
13b615c
Compare
legendecas
approved these changes
Mar 4, 2024
legendecas
added
the
commit-queue
UlisesGascon
approved these changes
Mar 4, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in bf4a63e |
lucshi
deleted the
async_hooks/async-local-storage-getstore-nested-resources.js
branch
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
storage-getstore-nested-resources.js Fixes: nodejs#50571 PR-URL: nodejs#51420 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storage-getstore-nested-resources.js
Before applying this PR, the real logic code of "aync hooks" is not measured accurately.
<style> </style>After increasing the iteration value, the test case behavior made sense.