lib: enable WebSocket by default #51594

Uzlopak · 2024-01-29T13:11:54Z

For node 22 we enable WebSocket by default.

Is the target correct?

doc/api/globals.md

mcollina

lgtm

targos · 2024-01-31T08:10:24Z

It seems to break a lot of tests.

Uzlopak · 2024-01-31T12:53:25Z

Let me investigate this

Uzlopak · 2024-01-31T15:07:58Z

@targos
I checked it. It starts erroring when i set in node_options.h experimental_websocket to true

But I have no clue, why this results in async hooks issues.

Uzlopak · 2024-01-31T18:24:34Z

I think I should also do thinks like in #51598

do not load WebSocket in all tests use global WebSocket for benchmark

targos · 2024-02-02T11:49:06Z

Rebased and adapted the code after lib: define FormData and fetch etc. in the built-in snapshot #51598.
Added a fix for the tests + simplify a benchmark.

nodejs-github-bot · 2024-02-02T12:29:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57018/

nodejs-github-bot · 2024-02-04T14:03:40Z

Landed in c975384

PR-URL: nodejs#51594 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Notable Changes: TBD Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: TBD Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Notable Changes: TBD Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Semver-Major Commits: build: * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) #52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52465 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #52465 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #52465 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52465 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52465 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52465 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52465 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52465 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52465 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52465 * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) #52465 * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293 * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) #52465 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293 * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) #52465 * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Semver-Major Commits: build: * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) nodejs#52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) nodejs#49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) nodejs#52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) nodejs#51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) nodejs#50973 deps: * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) nodejs#52465 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#52465 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) nodejs#52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) nodejs#52293 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) nodejs#52293 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) nodejs#51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) nodejs#51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) nodejs#50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) nodejs#50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) nodejs#51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) nodejs#51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) nodejs#50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) nodejs#52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) nodejs#51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) nodejs#50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) nodejs#50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) nodejs#51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) nodejs#51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) nodejs#52172 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) nodejs#51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) nodejs#50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) nodejs#52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) nodejs#50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) nodejs#52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) nodejs#51577 tools: * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) nodejs#51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) nodejs#51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) nodejs#50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) nodejs#51360 PR-URL: nodejs#52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

In node v22, websocket is enabled by default nodejs/node#51594 This will cause an error on following line when the global.Websocket would be true. const WS = global.WebSocket || require('ws'); global.WebSocket: This will points to Node.js's native WebSocket, which does not include a Server class. require('ws'): The ws package includes both WebSocket and WebSocket.Server, but this fallback is skipped because global.WebSocket is already defined in Node.js v22

In node v22, websocket is enabled by default nodejs/node#51594 This will cause an error on following line when the global.Websocket would be true. const WS = global.WebSocket || require('ws'); global.WebSocket: This will points to Node.js's native WebSocket, which does not include a Server class. require('ws'): The ws package includes both WebSocket and WebSocket.Server, but this fallback is skipped because global.WebSocket is already defined in Node.js v22 Signed-off-by: Ashish Pandey <aspandey@redhat.com>

Uzlopak marked this pull request as ready for review January 29, 2024 13:12

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jan 29, 2024

Uzlopak commented Jan 29, 2024

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

Uzlopak force-pushed the expose-websocket-by-default branch from 5051680 to 6858b5f Compare January 29, 2024 13:15

Uzlopak changed the title ~~feat: enable WebSocket by default~~ lib: enable WebSocket by default Jan 29, 2024

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 29, 2024

Uzlopak force-pushed the expose-websocket-by-default branch from 6858b5f to b9bdfc3 Compare January 29, 2024 13:23

mcollina approved these changes Jan 29, 2024

View reviewed changes

UlisesGascon approved these changes Jan 29, 2024

View reviewed changes

mcollina requested review from ronag, targos and ShogunPanda January 30, 2024 20:41

ShogunPanda approved these changes Jan 31, 2024

View reviewed changes

ronag approved these changes Jan 31, 2024

View reviewed changes

JMTK mentioned this pull request Jan 31, 2024

Add support for native NodeJS WebSocket discordjs/discord.js#10109

Open

Uzlopak force-pushed the expose-websocket-by-default branch from b9bdfc3 to 2722af1 Compare January 31, 2024 15:06

Uzlopak and others added 2 commits February 2, 2024 12:25

lib: enable WebSocket by default

68b38a6

fixup! lib: enable WebSocket by default

3f16766

do not load WebSocket in all tests use global WebSocket for benchmark

targos force-pushed the expose-websocket-by-default branch from 2722af1 to 3f16766 Compare February 2, 2024 11:48

targos added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 2, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2024

trivikr approved these changes Feb 4, 2024

View reviewed changes

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 4, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 4, 2024

nodejs-github-bot merged commit c975384 into nodejs:main Feb 4, 2024
58 checks passed

Uzlopak deleted the expose-websocket-by-default branch February 4, 2024 14:07

RafaelGSS mentioned this pull request Apr 12, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

benjamingr mentioned this pull request Apr 21, 2024

websocket: proposal for a new core module #49478

Closed

regseb mentioned this pull request Apr 25, 2024

[WebSocket] Add CloseEvent #50275

Closed

colinrotherham mentioned this pull request May 1, 2024

Check for unsupported "engines" package.json fields webdriverio/webdriverio#12638

Closed

8 tasks

bizob2828 mentioned this pull request Jul 9, 2024

[spike]: Research additional instrumentation points in Node 22 newrelic/node-newrelic#2304

Closed

aspandey mentioned this pull request Nov 7, 2024

noobaa/core: remove global websocket noobaa/noobaa-core#8514

Merged

ebadiere mentioned this pull request Nov 11, 2024

Upgrade to Node JS v20 hashgraph/hedera-json-rpc-relay#3156

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: enable WebSocket by default #51594

lib: enable WebSocket by default #51594

Uzlopak commented Jan 29, 2024 •

edited

Loading

mcollina left a comment

targos commented Jan 31, 2024

Uzlopak commented Jan 31, 2024

Uzlopak commented Jan 31, 2024

Uzlopak commented Jan 31, 2024

targos commented Feb 2, 2024

nodejs-github-bot commented Feb 2, 2024

nodejs-github-bot commented Feb 4, 2024

lib: enable WebSocket by default #51594

lib: enable WebSocket by default #51594

Conversation

Uzlopak commented Jan 29, 2024 • edited Loading

mcollina left a comment

Choose a reason for hiding this comment

targos commented Jan 31, 2024

Uzlopak commented Jan 31, 2024

Uzlopak commented Jan 31, 2024

Uzlopak commented Jan 31, 2024

targos commented Feb 2, 2024

nodejs-github-bot commented Feb 2, 2024

nodejs-github-bot commented Feb 4, 2024

Uzlopak commented Jan 29, 2024 •

edited

Loading