console: colorize console error and warn #51629

MrJithil · 2024-02-01T08:27:28Z

Related to : 40361

Colorise string type args of console.error and console.warn. We are skipping the non-string types.

Tasks:

Run CITGM

MrJithil · 2024-02-01T08:27:59Z

Will add test cases if this feature is acceptable

lib/internal/console/constructor.js

MrJithil · 2024-02-05T11:32:46Z

@MoLow I have changed the value of clear from '\u001bc' to '\u001b[0m'. Please check.

ruyadorno · 2024-02-05T18:48:59Z

I believe it's important to run through citgm to gauge the impact of this change.

marco-ippolito · 2024-03-15T15:10:16Z

I once again believe this should be marked as semver major change: #51503

nodejs-github-bot · 2024-04-27T14:46:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58746/

MrJithil · 2024-04-30T14:34:16Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3422

Could you please help me to run this CIGTM? I haven't run this before and felt a little confusing. Since these tests are time consuming, thought to take help or opinion before retrying it.

aduh95 · 2024-05-05T08:41:15Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3422

Could you please help me to run this CIGTM? I haven't run this before and felt a little confusing. Since these tests are time consuming, thought to take help or opinion before retrying it.

$ ncu-ci.js citgm 3421 3422

FAILURE: 6 failures in 3422 not present in 3421


┌────────────────────────┬──────────────────┬───────────────────────┐
│        (index)         │        0         │           1           │
├────────────────────────┼──────────────────┼───────────────────────┤
│       osx11-x64        │                  │                       │
│      rhel8-s390x       │                  │                       │
│       win-vs2022       │                  │                       │
│ alpine-last-latest-x64 │                  │                       │
│       rhel8-x64        │ 'undici-v6.14.1' │                       │
│      debian12-x64      │                  │                       │
│      debian11-x64      │  'jest-v0.0.0'   │    'semver-v7.6.0'    │
│   fedora-latest-x64    │                  │                       │
│     rhel8-ppc64le      │  'pino-v8.19.0'  │ 'prom-client-v15.1.2' │
│      aix72-ppc64       │                  │                       │
│     ubuntu2204-64      │ 'undici-v6.14.1' │                       │
│   alpine-latest-x64    │                  │                       │
│ fedora-last-latest-x64 │                  │                       │
└────────────────────────┴──────────────────┴───────────────────────┘

Now it's a matter of investigating whether those failures were caused by this PR or something else. For semver and prom-client, that's easy, No space left of device, so unrelated. For the other ones, it would require more careful review – but it seems fair to say landing this PR would not cause to much trouble to the ecosystem.

prints console error in red and warn in yellow PR-URL: #51629 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: James M Snell <jasnell@gmail.com>

MrJithil · 2024-05-08T13:58:23Z

Landed in a833c9e

prints console error in red and warn in yellow PR-URL: #51629 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: James M Snell <jasnell@gmail.com>

Julian24Design · 2024-05-18T05:39:12Z

Updated node to latest version, but console.error still outputs unclolored text. Is there any configuration required to achieve this?

prints console error in red and warn in yellow PR-URL: #51629 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: James M Snell <jasnell@gmail.com>

prints console error in red and warn in yellow PR-URL: nodejs#51629 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: James M Snell <jasnell@gmail.com>

Jason3S · 2024-06-29T09:49:00Z

I'm a bit surprised that this landed without a link to the discussion. #40361 is a feature request, but doesn't have a real discussion around the pros/cons and how it will impact the nodejs ecosystem.

I would have rather seen color added to the formatting of Errors instead of blanket red/yellow for console.error/console.warn.

I realize that in some way, this PR makes the behavior closer to that in the browser, but browsers do not have CLI applications.

I treat console.log and console.error as separate channels. Traditionally stdout is used for output of the program. It contains the result to be used, think grep. stderr is used for diagnostics, status, and messages to the user while the application is running. Color is not implied.

I would rather that this PR implemented color as a opt in vs trying to figure out how to opt out.

Recent versions of Node.js [print console.error() in red](nodejs/node#51629), changing the color of convex CLI output unintentionally. Change everywhere we `console.error` as a means to write to stderr to `process.stderr.write` calls. GitOrigin-RevId: 134e5302858c309e3a7fd9d470a685d9bf60b1df

The output of console.Console is colorized in Node.js >=20.15 <22.10 due to nodejs/node#51629 and nodejs/node#54677. Handle this in our test cases by comparing the output to the output of console.Console on a PassThrough stream. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>

nodejs-github-bot added console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. labels Feb 1, 2024

MrJithil force-pushed the colorize-console-error-and-warning branch 5 times, most recently from 827fe0c to b69e24d Compare February 1, 2024 13:22

MoLow reviewed Feb 4, 2024

View reviewed changes

lib/internal/console/constructor.js Outdated Show resolved Hide resolved

MrJithil force-pushed the colorize-console-error-and-warning branch 8 times, most recently from 0a37526 to 3b4f498 Compare February 5, 2024 11:30

MrJithil force-pushed the colorize-console-error-and-warning branch from 3b4f498 to d5ac03b Compare February 5, 2024 11:39

ruyadorno added the needs-citgm PRs that need a CITGM CI run. label Feb 5, 2024

MrJithil force-pushed the colorize-console-error-and-warning branch from d5ac03b to 3bf4dbf Compare February 6, 2024 11:26

MrJithil force-pushed the colorize-console-error-and-warning branch from 3bf4dbf to d07b7b4 Compare March 14, 2024 09:32

marco-ippolito mentioned this pull request Mar 15, 2024

doc: document console changes as breaking #51503

Closed

marco-ippolito added the blocked PRs that are blocked by other issues or PRs. label Mar 15, 2024

This comment was marked as outdated.

Sign in to view

MrJithil force-pushed the colorize-console-error-and-warning branch 2 times, most recently from 471a7d4 to 8747c98 Compare March 20, 2024 10:09

MrJithil requested a review from MoLow March 20, 2024 10:10

This comment was marked as outdated.

Sign in to view

jasnell approved these changes Apr 27, 2024

View reviewed changes

MrJithil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 30, 2024

MrJithil closed this May 8, 2024

MrJithil deleted the colorize-console-error-and-warning branch May 8, 2024 13:59

ruyadorno removed the blocked PRs that are blocked by other issues or PRs. label May 13, 2024

targos mentioned this pull request May 13, 2024

v22.2.0 release proposal #52971

Merged

marco-ippolito mentioned this pull request Jun 17, 2024

v20.15.0 proposal #53486

Merged

RedYetiDev mentioned this pull request Jun 26, 2024

Colorize console.error output to make it distinguishable #40361

Closed

mattbrictson mentioned this pull request Jun 28, 2024

[Bug]: Summary is red, implying error, even when no issues (Node 20.15+) streetsidesoftware/cspell#5821

Closed

1 task

Jason3S mentioned this pull request Jul 1, 2024

console.error unexpectedly turns output red #53661

Closed

Triskae mentioned this pull request Jul 1, 2024

console.error/warn causes problem with GCP Cloud logging #53665

Closed

RedYetiDev mentioned this pull request Aug 31, 2024

Revert "console: colorize console error and warn" #54677

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

console: colorize console error and warn #51629

console: colorize console error and warn #51629

MrJithil commented Feb 1, 2024 •

edited

Loading

MrJithil commented Feb 1, 2024

MrJithil commented Feb 5, 2024

ruyadorno commented Feb 5, 2024 •

edited

Loading

marco-ippolito commented Mar 15, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 27, 2024

MrJithil commented Apr 30, 2024

aduh95 commented May 5, 2024

MrJithil commented May 8, 2024

Julian24Design commented May 18, 2024

Jason3S commented Jun 29, 2024 •

edited

Loading

console: colorize console error and warn #51629

console: colorize console error and warn #51629

Conversation

MrJithil commented Feb 1, 2024 • edited Loading

MrJithil commented Feb 1, 2024

MrJithil commented Feb 5, 2024

ruyadorno commented Feb 5, 2024 • edited Loading

marco-ippolito commented Mar 15, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 27, 2024

MrJithil commented Apr 30, 2024

aduh95 commented May 5, 2024

MrJithil commented May 8, 2024

Julian24Design commented May 18, 2024

Jason3S commented Jun 29, 2024 • edited Loading

MrJithil commented Feb 1, 2024 •

edited

Loading

ruyadorno commented Feb 5, 2024 •

edited

Loading

Jason3S commented Jun 29, 2024 •

edited

Loading