-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: change ExperimentalWarnings
to ExperimentalWarning
#51741
Conversation
you need to edit your first commit message you can do it like this : |
Sure, @mertcanaltin. Working on modifying the commit message and rebasing my PR now. Will post here when done. |
ExperimentalWarnings
to ExperimentalWarning
ExperimentalWarnings
to ExperimentalWarning
@mertcanaltin - Just rebased and force pushed the commit with the modified commit message. PS. Notes for myself
|
Landed in 123dc51 |
PR-URL: #51741 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
PR-URL: #51741 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
PR-URL: #51741 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
PR-URL: #51741 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
PR-URL: nodejs#51741 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Change Summary
This PR changes
ExperimentalWarnings
toExperimentalWarning
in the documentation for the latest version of NodeJS as of this writing -v21.6.1
.Why?
I am using the experimental JSON Modules feature within my NodeJS project. Although the JSON Modules feature works, whenever I execute my ES Module based JavaScript file, I would receive the following warning:
After reading through the documentation under the section titled
--disable-warning=code-or-type
, I tried to suppress theExperimentalWarning
by changing the followingstart
script within mypackage.json
file:But I still received the aforementioned
ExperimentalWarning
within my console.After re-reading the documentation (and referring other documentations - like this comment on issue #30810), instead of the plural version (
ExperimentalWarnings
), I tried the singular version (ExperimentalWarning
):And it worked! The warning was suppressed.
Hence, this PR to address the confusion in the documentation.