Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix tests for coverage generation #51816

Closed
wants to merge 2 commits into from
Closed

test: fix tests for coverage generation #51816

wants to merge 2 commits into from

Commits on Feb 20, 2024

  1. test: fix test-bootstrap-modules for coverage generation 

    The internal binding profiler is loaded if the test is run with
NODE_V8_COVERAGE.
    @joyeecheung
    joyeecheung committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    68b82b7 View commit details
    Browse the repository at this point in the history

  2. test: fix test-debugger-profile for coverage generation 

    The child process should not inherit NODE_V8_COVERAGE because
that clobbers the inspector output the test is checking.
    @joyeecheung
    joyeecheung committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    a59e76d View commit details
    Browse the repository at this point in the history