-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add Paolo to TSC members #51825
Conversation
Refs: nodejs/TSC#1501 Signed-off-by: Michael Dawson <midawson@redhat.com>
@ShogunPanda welcome ! |
Thank you a very lot! It's a huge honor! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proudly LGTM!
Fast-track has been requested by @mhdawson. Please 👍 to approve. |
Commit Queue failed- Loading data for nodejs/node/pull/51825 ✔ Done loading data for nodejs/node/pull/51825 ----------------------------------- PR info ------------------------------------ Title doc: add Paolo to TSC members (#51825) Author Michael Dawson (@mhdawson) Branch mhdawson:addPaolo -> nodejs:main Labels doc, fast-track, author ready Commits 3 - doc: add Paolo to TSC members - fix alphabetization - remove extra space Committers 2 - Michael Dawson - GitHub PR-URL: https://github.com/nodejs/node/pull/51825 Refs: https://github.com/nodejs/TSC/issues/1501 Reviewed-By: Paolo Insogna Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51825 Refs: https://github.com/nodejs/TSC/issues/1501 Reviewed-By: Paolo Insogna Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 21 Feb 2024 17:01:07 GMT ✔ Approvals: 3 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/51825#pullrequestreview-1893861202 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/51825#pullrequestreview-1894019219 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51825#pullrequestreview-1894188370 ℹ This PR is being fast-tracked ✘ This PR needs to wait 45 more hours to land (or 0 hours if there are 2 more approvals (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7994538952 |
Commit Queue failed- Loading data for nodejs/node/pull/51825 ✔ Done loading data for nodejs/node/pull/51825 ----------------------------------- PR info ------------------------------------ Title doc: add Paolo to TSC members (#51825) Author Michael Dawson (@mhdawson) Branch mhdawson:addPaolo -> nodejs:main Labels doc, fast-track, author ready Commits 3 - doc: add Paolo to TSC members - fix alphabetization - remove extra space Committers 2 - Michael Dawson - GitHub PR-URL: https://github.com/nodejs/node/pull/51825 Refs: https://github.com/nodejs/TSC/issues/1501 Reviewed-By: Paolo Insogna Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51825 Refs: https://github.com/nodejs/TSC/issues/1501 Reviewed-By: Paolo Insogna Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 21 Feb 2024 17:01:07 GMT ✔ Approvals: 4 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/51825#pullrequestreview-1893861202 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/51825#pullrequestreview-1894019219 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51825#pullrequestreview-1894188370 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51825#pullrequestreview-1894483078 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51825 From https://github.com/nodejs/node * branch refs/pull/51825/merge -> FETCH_HEAD ✔ Fetched commits as a0ac8bd4d85e..f048ea69ee1f -------------------------------------------------------------------------------- [main 31f88deb16] doc: add Paolo to TSC members Author: Michael Dawson Date: Wed Feb 21 16:59:33 2024 +0000 1 file changed, 2 insertions(+) [main 2106ddb1dd] fix alphabetization Author: Michael Dawson Date: Wed Feb 21 12:45:17 2024 -0500 1 file changed, 3 insertions(+), 2 deletions(-) [main 4217070a4d] remove extra space Author: Michael Dawson Date: Wed Feb 21 12:46:10 2024 -0500 1 file changed, 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/7996169474 |
Landed in 5dfff3a |
Refs: nodejs/TSC#1501 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #51825 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Refs: nodejs/TSC#1501 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #51825 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Refs: nodejs/TSC#1501 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #51825 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Refs: nodejs/TSC#1501 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #51825 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Refs: nodejs/TSC#1501 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#51825 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Refs: nodejs/TSC#1501