node: set process._eventsCount to 0 on startup #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we just call constructor from JS side? |
|
LGTM |
mscdex
added
events
|
@vkurchatkin we certainly could. I played with it and didn't see any difference in performance. Any particular reason you would prefer that? |
|
LGTM |
| @@ -18,3 +18,6 @@ process.on('SIGPIPE', common.mustCall((data) => { | |||
| process.emit('normal', 'normalData'); | |||
| process.emit(sym, 'symbolData'); | |||
| process.emit('SIGPIPE', 'signalData'); | |||
|
|
|||
| assert.strictEqual(typeof process._eventsCount, 'number'); | |||
| assert.strictEqual(isNaN(process._eventsCount), false); | |||
There was a problem hiding this comment.
Both these tests can be combined with Number.isNaN
That would be my suggestion as well. Aside, if |
evanlucas
force-pushed
the
proceventscount
branch
2 times, most recently
from
867fbf8
to
3589630
Compare
|
Ok, changed to set on the JS side. Also fixed up the test per @thefourtheye. CI: https://ci.nodejs.org/job/node-test-pull-request/1657/ Thanks! |
| @@ -18,3 +18,5 @@ process.on('SIGPIPE', common.mustCall((data) => { | |||
| process.emit('normal', 'normalData'); | |||
| process.emit(sym, 'symbolData'); | |||
| process.emit('SIGPIPE', 'signalData'); | |||
|
|
|||
| assert.strictEqual(Number.isNaN(process._eventsCount), false); | |||
There was a problem hiding this comment.
Shouldn't you use global isNaN() here? Number.isNaN('boom') would pass because it returns false.
There was a problem hiding this comment.
ah good catch. fixing
evanlucas
force-pushed
the
proceventscount
branch
from
3589630
to
ee4f272
Compare
|
Fixed Ben's comment. |
|
LGTM |
process is an EventEmitter. There are operations that increment and decrement the _eventsCount property of an EventEmitter. process._eventsCount would previously get set to NaN. This change makes process._eventsCount be calculated as expected. PR-URL: nodejs#5208 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas
force-pushed
the
proceventscount
branch
from
ee4f272
to
31ebda2
Compare
|
Landed in 31ebda2. Thanks! |
rvagg
pushed a commit
that referenced
this pull request
Feb 15, 2016
process is an EventEmitter. There are operations that increment and decrement the _eventsCount property of an EventEmitter. process._eventsCount would previously get set to NaN. This change makes process._eventsCount be calculated as expected. PR-URL: #5208 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
stefanmb
pushed a commit
to stefanmb/node
that referenced
this pull request
Feb 23, 2016
process is an EventEmitter. There are operations that increment and decrement the _eventsCount property of an EventEmitter. process._eventsCount would previously get set to NaN. This change makes process._eventsCount be calculated as expected. PR-URL: nodejs#5208 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 1, 2016
process is an EventEmitter. There are operations that increment and decrement the _eventsCount property of an EventEmitter. process._eventsCount would previously get set to NaN. This change makes process._eventsCount be calculated as expected. PR-URL: #5208 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 1, 2016
process is an EventEmitter. There are operations that increment and decrement the _eventsCount property of an EventEmitter. process._eventsCount would previously get set to NaN. This change makes process._eventsCount be calculated as expected. PR-URL: #5208 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
process is an EventEmitter. There are operations that increment and decrement the _eventsCount property of an EventEmitter. process._eventsCount would previously get set to NaN. This change makes process._eventsCount be calculated as expected. PR-URL: #5208 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processis anEventEmitter. There are operations that increment anddecrement the
_eventsCountproperty of anEventEmitter.process._eventsCountwould previously get set toNaN. This change makesprocess._eventsCountbe calculated as expected.