deps: update undici to 6.10.2 #52175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
dependencies
|
Review requested:
|
|
cc @nodejs/undici |
metcoder95
approved these changes
Mar 21, 2024
marco-ippolito
approved these changes
Mar 21, 2024
github-actions
bot
removed
the
request-ci
|
Could we fast track? |
|
Fast-track has been requested by @mcollina. Please 👍 to approve. |
|
We don't need to. There's no release scheduled this week |
KhafraDev
approved these changes
Mar 21, 2024
RafaelGSS
approved these changes
Mar 21, 2024
trivikr
approved these changes
Mar 24, 2024
mcollina
added
request-ci
github-actions
bot
removed
the
request-ci
|
Looks like this is breaking the withoutintl builds. |
ludovicm67
reviewed
Mar 26, 2024
| @@ -226,7 +248,7 @@ await fetch('https://example.com', { body: data, method: 'POST', duplex: 'half' | |||
|
|
|||
| - half | |||
|
|
|||
| In this implementation of fetch, `request.duplex` must be set if `request.body` is `ReadableStream` or `Async Iterables`. And fetch requests are currently always be full duplex. More detail refer to [Fetch Standard.](https://fetch.spec.whatwg.org/#dom-requestinit-duplex) | |||
| In this implementation of fetch, `request.duplex` must be set if `request.body` is `ReadableStream` or `Async Iterables`, however, fetch requests are currently always full duplex. For more detail refer to the [Fetch Standard.](https://fetch.spec.whatwg.org/#dom-requestinit-duplex). | |||
There was a problem hiding this comment.
I was just reading a bit the changes of this PR, and just saw this:
Suggested change
| In this implementation of fetch, `request.duplex` must be set if `request.body` is `ReadableStream` or `Async Iterables`, however, fetch requests are currently always full duplex. For more detail refer to the [Fetch Standard.](https://fetch.spec.whatwg.org/#dom-requestinit-duplex). | |
| In this implementation of fetch, `request.duplex` must be set if `request.body` is `ReadableStream` or `Async Iterables`, however, fetch requests are currently always full duplex. For more details, refer to the [Fetch Standard](https://fetch.spec.whatwg.org/#dom-requestinit-duplex). |
nodejs-github-bot
changed the title
github-actions
bot
removed
the
request-ci
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of undici to 6.10.2.