fs: define constants with const #522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define fs constants using const, as the newer version of v8 supports it, and appears to be capable of optimizing.
|
This is not really an alternative to #507, more like an addition. The fact that constants are defined in fs.js does not make the properties of the exports object unwritable. |
|
LGTM and it could even be less conservative IMO. V8 used to have trouble optimizing let/const-scoped bindings sometimes but I did a quick check of the source code and it looks like that has been resolved. |
cjihrig
added a commit
that referenced
this pull request
Jan 20, 2015
Define fs constants using const, as the newer version of v8 supports it, and appears to be capable of optimizing. PR-URL: #522 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 86eda17. @bnoordhuis I wasn't sure if |
|
And @targos, thanks I didn't account for the |
|
@bnoordhuis what's your opinion on setting modules imported by |
|
@cjihrig +1 from me, no reason not to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
fsconstants usingconst. In the tests that I've done, it appears that v8 is able to optimizeconst. Suggesting this as an alternative to #507. If this is acceptable, I'd be interested in updating other constants throughout the JS codebase.