-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: fix http-parser regression (v4.x) #5238
Conversation
/cc @thealphanerd @rvagg ... this will need to go into v4.3.1 |
Fixes http-parser regression with IS_HEADER_CHAR check Add test case for obstext characters (> 0x80) is header
5f14f3f
to
fa6571c
Compare
LGTM |
Only failure is infra related |
LGTM |
Fixes http-parser regression with IS_HEADER_CHAR check Add test case for obstext characters (> 0x80) is header PR-URL: #5238 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com>
Landed as 188cff3 |
Notable changes: * buffer: make byteLength work with Buffer correctly (Jackson Tian) - nodejs#4738 * debugger: guard against call from non-node context (Ben Noordhuis) - nodejs#4328 * node_contextify: do not incept debug context (Myles Borins) - nodejs#4819 * deps: update to http-parser 2.5.2 (James Snell) - nodejs#5238
Notable changes: * buffer: make byteLength work with Buffer correctly (Jackson Tian) - #4738 * debugger: guard against call from non-node context (Ben Noordhuis) - #4328 * node_contextify: do not incept debug context (Myles Borins) - #4819 * deps: update to http-parser 2.5.2 (James Snell) - #5238 PR-URL: #5200 (comment)
This might help someone else, but this was the cause of a bunch of mystery nginx "upstream prematurely closed connection while reading response header from upstream" when proxying to node on v4.3.0. The proxied request bails so early that it appears nothing happens from the node side. You can bind to |
The new IS_HEADER_CHAR check in http-parser is improperly
checking char when it should be checking unsigned char.
/cc @ChALkeR