doc: add simple http clientError example #5248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
http
| }); | ||
| server.on('clientError', (err, socket) => { | ||
| socket.end('HTTP/1.1 400 Bad Request\r\n\r\n'); | ||
| server.close(); |
There was a problem hiding this comment.
I don't think that server.close() is relevant here.
|
Otherwise LGTM |
The clientError event allows proper http 4xx responses to be returned when a parse error occurs, but the documentation did not demonstrate how to use it.
jasnell
force-pushed
the
http-client-error-doc
branch
from
329aa60 to
649c3b0
Compare
|
@indutny ... removed the |
|
LGTM |
|
LGTM, please land ;) |
jasnell
added a commit
that referenced
this pull request
Feb 17, 2016
The clientError event allows proper http 4xx responses to be returned when a parse error occurs, but the documentation did not demonstrate how to use it. PR-URL: #5248 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
|
btw, I believe this currently only works in master... |
|
Only master, right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clientError event allows proper http 4xx responses to
be returned when a parse error occurs, but the documentation
did not demonstrate how to use it.
/cc @nodejs/http @indutny