Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: prepare custom rules for ESLint v9 #52889

Merged
merged 2 commits into from
May 9, 2024
Merged

tools: prepare custom rules for ESLint v9 #52889

merged 2 commits into from
May 9, 2024

Conversation

targos
Copy link
Member

@targos targos commented May 8, 2024

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 8, 2024
@targos
Copy link
Member Author

targos commented May 8, 2024

Easier to review with https://github.com/nodejs/node/pull/52889/files?diff=unified&w=1

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Fast-track has been requested by @targos. Please 👍 to approve.

@targos targos mentioned this pull request May 8, 2024
Merged
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59031/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59035/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59039/

@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2024
@targos
Copy link
Member Author

targos commented May 9, 2024

/cc @aduh95

@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2024
@nodejs-github-bot nodejs-github-bot merged commit 3c1069b into nodejs:main May 9, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3c1069b

@targos targos deleted the eslint-rules-v9 branch May 9, 2024 16:59
targos added a commit that referenced this pull request May 11, 2024
@targos
tools: prepare custom rules for ESLint v9
646a094 
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0
PR-URL: #52889
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@targos targos mentioned this pull request May 13, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@targos @marco-ippolito
tools: prepare custom rules for ESLint v9
3d13a6a 
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0
PR-URL: #52889
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@targos @marco-ippolito
tools: prepare custom rules for ESLint v9
5700600 
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0
PR-URL: #52889
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@targos @eliphazbouye
tools: prepare custom rules for ESLint v9
5e8b062 
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0
PR-URL: nodejs#52889
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@targos @bmeck
tools: prepare custom rules for ESLint v9
5b3fdf1 
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0
PR-URL: nodejs#52889
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@aduh95 aduh95 aduh95 approved these changes

@MoLow MoLow MoLow approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @lpinca @anonrig @MoLow @aduh95 @VoltrexKeyva