dns: add TLSA record query support

[rithvikvibhu]

This PR adds resolveTlsa so that the resolver can query TLSA records.

c-ares added the parser in c-ares/c-ares#600 and @bradh352 (thanks!) provided some code to get started with: #39569 (comment)

Refs: #39569

P.S. I'm new to both node core as well as C++ so the code may be unideal, am open to any changes to be made.

Also, I'm not sure about the YAML markup in docs, what should the "Added in" say?

And is this considered a Notable Change?

[rithvikvibhu]

I've updated to fix linting and formatting, but not sure about the LeakSanitizer: detected memory leaks one.

Tried reproducing it locally with tools/test.py but could not, all tests always run without issues. And it seems to be complaining about dnsrec but I think it's handled properly? Would love some advice here.

[bradh352]

might be useful to define the known values for the TLSA records like we do in c-ares with ares_tlsa_match_t, ares_tlsa_selector_t, and ares_tlsa_usage_t

[rithvikvibhu]

Fixed the mem leak and confirmed the asan test passes (on a different branch, not in this PR: https://github.com/rithvikvibhu/node/actions/runs/9137751681/job/25128086198)

I think it's ready for review (assuming all checks pass).

---

@bradh352 I searched but couldn't find constants defined in dns for any other type, they are all stored and returned as regular objects. For ex, ParseMxReply:

node/src/cares_wrap.cc

Lines 301 to 311 in 559212e

	Local<Object> mx_record = Object::New(env->isolate());
	mx_record->Set(env->context(),
	env->exchange_string(),
	OneByteString(env->isolate(), current->host)).Check();
	mx_record->Set(env->context(),
	env->priority_string(),
	Integer::New(env->isolate(), current->priority)).Check();
	if (need_type)
	mx_record->Set(env->context(),
	env->type_string(),
	env->dns_mx_string()).Check();

[rithvikvibhu]

@lpinca can you approve the workflow again? I believe all check errors are fixed now. Also, any idea if someone or a group must be tagged for reviewing? (I don't mind if it takes time, just making sure I understand the process)

[Trott]

@nodejs/dns

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59604/

[rithvikvibhu]

The only failing test is benchmark/test-benchmark-crypto, which this PR does not touch. There is an issue with the same error and a PR to mark it as flaky:

• flaky: benchmark/test-benchmark-crypto #52690
• test: mark test-benchmark-crypto as flaky #52955

I think we just wait till #52955 is merged, then I rebase?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59614/

[Trott]

This needs someone to review it. I already pinged @nodejs/dns 2 weeks ago, so now I'm going to try current collaborators who show up a lot in git blame src/cares_wrap.cc: @jasnell @addaleax @XadillaX @bnoordhuis @ShogunPanda @joyeecheung

[ShogunPanda]

I'm not really a C++ expert but it looks fine to me.

[bradh352]

I'd probably recommend checking this return value to not be NULL before attempting to memcpy it.

[rithvikvibhu]

I'm looking at the possible codes and ARES_ENODATA seems to be the closest match status code to return in this case.
Or do you think we should just skip this record (if null data) without any errors?