src: do not use soon-to-be-deprecated V8 API #53174

targos · 2024-05-27T13:12:11Z

V8 announced deprecation of the following methods:

v8::Object::SetAccessor(...) in favor of v8::Object::SetNativeDataProperty(...),
v8::ObjectTemplate::SetNativeDataProperty(...) with AccessControl parameter in favor of v8::ObjectTemplate::SetNativeDataProperty(...) without AccessControl parameter.

This slightly changes behavior of the following properties:

process.debugPort (for worker processes),
process.title (for worker processes),
process.ppid.

The difference is that they will now behave like a regular writable JavaScript data properties - in case setter callback is not provided they will be be reconfigured from a native data property (the one that calls C++ callbacks upon get/set operations) to a real data property (so subsequent reads will no longer trigger C++ getter callbacks).

targos · 2024-05-27T13:12:21Z

This is a port of v8#179

V8 announced deprecation of the following methods: - v8::Object::SetAccessor(...) in favor of v8::Object::SetNativeDataProperty(...), - v8::ObjectTemplate::SetNativeDataProperty(...) with AccessControl parameter in favor of v8::ObjectTemplate::SetNativeDataProperty(...) without AccessControl parameter. See https://crrev.com/c/5006387. This slightly changes behavior of the following properties: - process.debugPort (for worker processes), - process.title (for worker processes), - process.ppid. The difference is that they will now behave like a regular writable JavaScript data properties - in case setter callback is not provided they will be be reconfigured from a native data property (the one that calls C++ callbacks upon get/set operations) to a real data property (so subsequent reads will no longer trigger C++ getter callbacks).

mhdawson

LGTM

mhdawson · 2024-05-27T17:53:08Z

@targos I assume you don't think it needs to be SemVer major despite changing the behavior?

targos · 2024-05-27T17:56:45Z

I haven't thought about it. It doesn't harm to make it major so I'll do it

targos · 2024-05-28T12:10:21Z

@nodejs/tsc

nodejs-github-bot · 2024-05-29T11:23:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59511/

nodejs-github-bot · 2024-05-29T13:10:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59516/

nodejs-github-bot · 2024-05-29T22:04:24Z

Landed in 0a3f930...bb8d293

V8 announced deprecation of the following methods: - v8::Object::SetAccessor(...) in favor of v8::Object::SetNativeDataProperty(...), - v8::ObjectTemplate::SetNativeDataProperty(...) with AccessControl parameter in favor of v8::ObjectTemplate::SetNativeDataProperty(...) without AccessControl parameter. See https://crrev.com/c/5006387. This slightly changes behavior of the following properties: - process.debugPort (for worker processes), - process.title (for worker processes), - process.ppid. The difference is that they will now behave like a regular writable JavaScript data properties - in case setter callback is not provided they will be be reconfigured from a native data property (the one that calls C++ callbacks upon get/set operations) to a real data property (so subsequent reads will no longer trigger C++ getter callbacks). PR-URL: #53174 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

V8 announced deprecation of the following methods: - v8::Object::SetAccessor(...) in favor of v8::Object::SetNativeDataProperty(...), - v8::ObjectTemplate::SetNativeDataProperty(...) with AccessControl parameter in favor of v8::ObjectTemplate::SetNativeDataProperty(...) without AccessControl parameter. See https://crrev.com/c/5006387. This slightly changes behavior of the following properties: - process.debugPort (for worker processes), - process.title (for worker processes), - process.ppid. The difference is that they will now behave like a regular writable JavaScript data properties - in case setter callback is not provided they will be be reconfigured from a native data property (the one that calls C++ callbacks upon get/set operations) to a real data property (so subsequent reads will no longer trigger C++ getter callbacks). PR-URL: nodejs#53174 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: TBD

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: #55338

nodejs/node#53174

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) nodejs#53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) nodejs#54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) nodejs#47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) nodejs#54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) nodejs#54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) nodejs#54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) nodejs#53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) nodejs#45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) nodejs#53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) nodejs#54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) nodejs#52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) nodejs#52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) nodejs#52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) nodejs#52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) nodejs#55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) nodejs#53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) nodejs#52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) nodejs#54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) nodejs#54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) nodejs#54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) nodejs#54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) nodejs#54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) nodejs#54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) nodejs#53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) nodejs#54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) nodejs#49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) nodejs#51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) nodejs#54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) nodejs#54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) nodejs#53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) nodejs#54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) nodejs#54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) nodejs#55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) nodejs#54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) nodejs#54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) nodejs#54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) nodejs#53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) nodejs#52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) nodejs#53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) nodejs#54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) nodejs#54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) nodejs#54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) nodejs#54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) nodejs#52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) nodejs#46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) nodejs#52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) nodejs#54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) nodejs#54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) nodejs#54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) nodejs#52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) nodejs#55020 PR-URL: nodejs#55338

* chore: bump Node.js to v22.9.0 * build: drop base64 dep in GN build nodejs/node#52856 * build,tools: make addons tests work with GN nodejs/node#50737 * fs: add fast api for InternalModuleStat nodejs/node#51344 * src: move package_json_reader cache to c++ nodejs/node#50322 * crypto: disable PKCS#1 padding for privateDecrypt nodejs-private/node-private#525 * src: move more crypto code to ncrypto nodejs/node#54320 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * src: shift more crypto impl details to ncrypto nodejs/node#54028 * src: switch crypto APIs to use Maybe<void> nodejs/node#54775 * crypto: remove DEFAULT_ENCODING nodejs/node#47182 * deps: update libuv to 1.47.0 nodejs/node#50650 * build: fix conflict gyp configs nodejs/node#53605 * lib,src: drop --experimental-network-imports nodejs/node#53822 * esm: align sync and async load implementations nodejs/node#49152 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * module: detect ESM syntax by trying to recompile as SourceTextModule nodejs/node#52413 * test: adapt debugger tests to V8 11.4 nodejs/node#49639 * lib: update usage of always on Atomics API nodejs/node#49639 * test: adapt test-fs-write to V8 internal changes nodejs/node#49639 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * deps: update libuv to 1.47.0 nodejs/node#50650 * src: use non-deprecated v8::Uint8Array::kMaxLength nodejs/node#50115 * src: update default V8 platform to override functions with location nodejs/node#51362 * src: add missing TryCatch nodejs/node#51362 * lib,test: handle new Iterator global nodejs/node#51362 * src: use non-deprecated version of CreateSyntheticModule nodejs/node#50115 * src: remove calls to recently deprecated V8 APIs nodejs/node#52996 * src: use new V8 API to define stream accessor nodejs/node#53084 * src: do not use deprecated V8 API nodejs/node#53084 * src: do not use soon-to-be-deprecated V8 API nodejs/node#53174 * src: migrate to new V8 interceptors API nodejs/node#52745 * src: use supported API to get stalled TLA messages nodejs/node#51362 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * test: make snapshot comparison more flexible nodejs/node#54375 * test: do not set concurrency on parallelized runs nodejs/node#52177 * src: move FromNamespacedPath to path.cc nodejs/node#53540 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * build: add option to enable clang-cl on Windows nodejs/node#52870 * chore: fixup patch indices * chore: add/remove changed files * esm: drop support for import assertions nodejs/node#54890 * build: compile with C++20 support nodejs/node#52838 * deps: update nghttp2 to 1.62.1 nodejs/node#52966 * src: parse inspector profiles with simdjson nodejs/node#51783 * build: add GN build files nodejs/node#47637 * deps,lib,src: add experimental web storage nodejs/node#52435 * build: add missing BoringSSL dep * src: rewrite task runner in c++ nodejs/node#52609 * fixup! build: add GN build files * src: stop using deprecated fields of v8::FastApiCallbackOptions nodejs/node#54077 * fix: shadow variable * build: add back incorrectly removed SetAccessor patch * fixup! fixup! build: add GN build files * crypto: fix integer comparison in crypto for BoringSSL * src,lib: reducing C++ calls of esm legacy main resolve nodejs/node#48325 * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * chore: fixup GN files for previous commit * src: move more crypto code to ncrypto nodejs/node#54320 * Fixup Perfetto ifdef guards * fix: missing electron_natives dep * fix: node_use_node_platform = false * fix: include src/node_snapshot_stub.cc in libnode * 5507047: [import-attributes] Remove support for import assertions https://chromium-review.googlesource.com/c/v8/v8/+/5507047 * fix: restore v8-sandbox.h in filenames.json * fix: re-add original-fs generation logic * fix: ngtcp2 openssl dep * test: try removing NAPI_VERSION undef * chore(deps): bump @types/node * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * buffer: fix out of range for toString nodejs/node#54553 * lib: rewrite AsyncLocalStorage without async_hooks nodejs/node#48528 * module: print amount of load time of a cjs module nodejs/node#52213 * test: skip reproducible snapshot test on 32-bit nodejs/node#53592 * fixup! src: move more crypto_dh.cc code to ncrypto * test: adjust emittedUntil return type * chore: remove redundant wpt streams patch * fixup! chore(deps): bump @types/node * fix: gn executable name on Windows * fix: build on Windows * fix: rename conflicting win32 symbols in //third_party/sqlite On Windows otherwise we get: lld-link: error: duplicate symbol: sqlite3_win32_write_debug >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_sleep >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_is_nt >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj * docs: remove unnecessary ts-expect-error after types bump * src: move package resolver to c++ nodejs/node#50322 * build: set ASAN detect_container_overflow=0 nodejs/node#55584 * chore: fixup rebase * test: disable failing ASAN test * win: almost fix race detecting ESRCH in uv_kill libuv/libuv#4341

targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels May 27, 2024

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 27, 2024

targos added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label May 27, 2024

targos force-pushed the v8-data-property branch from 741c559 to 3b148be Compare May 27, 2024 13:17

mhdawson approved these changes May 27, 2024

View reviewed changes

joyeecheung approved these changes May 28, 2024

View reviewed changes

benjamingr approved these changes May 28, 2024

View reviewed changes

targos added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 29, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024

RafaelGSS approved these changes May 29, 2024

View reviewed changes

jasnell approved these changes May 29, 2024

View reviewed changes

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2024

nodejs-github-bot closed this May 29, 2024

targos deleted the v8-data-property branch May 30, 2024 05:10

RafaelGSS mentioned this pull request Oct 9, 2024

2024-10-16, Version 23.0.0 (Current) #55338

Merged

codebytere added a commit to electron/electron that referenced this pull request Oct 16, 2024

src: do not use soon-to-be-deprecated V8 API

ad4902a

nodejs/node#53174

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

src: do not use soon-to-be-deprecated V8 API

cc9c210

nodejs/node#53174

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

src: do not use soon-to-be-deprecated V8 API

bbd3d87

nodejs/node#53174

codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024

src: do not use soon-to-be-deprecated V8 API

c13724f

nodejs/node#53174

codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024

src: do not use soon-to-be-deprecated V8 API

68cf1d9

nodejs/node#53174

codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024

src: do not use soon-to-be-deprecated V8 API

89b050f

nodejs/node#53174

codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024

src: do not use soon-to-be-deprecated V8 API

49d05d5

nodejs/node#53174

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: do not use soon-to-be-deprecated V8 API #53174

src: do not use soon-to-be-deprecated V8 API #53174

targos commented May 27, 2024

targos commented May 27, 2024

mhdawson left a comment

mhdawson commented May 27, 2024

targos commented May 27, 2024

targos commented May 28, 2024 •

edited

Loading

nodejs-github-bot commented May 29, 2024

nodejs-github-bot commented May 29, 2024

nodejs-github-bot commented May 29, 2024

src: do not use soon-to-be-deprecated V8 API #53174

src: do not use soon-to-be-deprecated V8 API #53174

Conversation

targos commented May 27, 2024

targos commented May 27, 2024

mhdawson left a comment

Choose a reason for hiding this comment

mhdawson commented May 27, 2024

targos commented May 27, 2024

targos commented May 28, 2024 • edited Loading

nodejs-github-bot commented May 29, 2024

nodejs-github-bot commented May 29, 2024

nodejs-github-bot commented May 29, 2024

targos commented May 28, 2024 •

edited

Loading