tools,doc: parse types in braces everywhere #5329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,6 +114,10 @@ function parseLists(input) { | |||
| var output = []; | |||
| output.links = input.links; | |||
| input.forEach(function(tok) { | |||
| if (tok.type === 'text' && tok.text) { | |||
There was a problem hiding this comment.
This will have side effects, only if we will write something like....
Some missing {type} or { code: 'without backquote' }
mscdex
added
doc
| @@ -6,13 +6,13 @@ Applications running in Node.js will generally experience four categories of | |||
| errors: | |||
|
|
|||
| - Standard JavaScript errors such as: | |||
| - [`EvalError`][]: thrown when a call to `eval()` fails. | |||
| - [`SyntaxError`][]: thrown in response to improper JavaScript language | |||
| - {EvalError} : thrown when a call to `eval()` fails. | |||
There was a problem hiding this comment.
Sorry @estliberitas , since #5641 fixes the broken links, do we still need to remove them?
|
+1... ok, LGTM! |
|
This needs a rebase now. |
|
@silverwind Done |
|
Oy.. looks like it needs another rebase. If you can get that I'll look at landing next week |
|
@jasnell I'll fix tmrw |
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`, `TypeError`, `URIError` to list of global types. Fix errors.markdown copy accordingly. Fixes #5325.
|
@jasnell done |
|
@nodejs/documentation ... another quick review please? :-) |
|
LGTM |
|
ping @jasnell |
|
LGTM |
|
Landed in eafd31a |
Closed
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`, `TypeError`, `URIError` to list of global types. Fix errors.markdown copy accordingly. Fixes: nodejs#5325. PR-URL: nodejs#5329 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
EvalError,RangeError,ReferenceError,SyntaxError,TypeError,URIErrorto list of global types. Fix errors.markdowncopy accordingly.
Fixes #5325.