-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: fix permission inspector crash #53389
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
theanarkh:fix_permission_inspector_crash
Jun 10, 2024
Merged
src: fix permission inspector crash #53389
nodejs-github-bot
merged 1 commit into
nodejs:main
from
theanarkh:fix_permission_inspector_crash
Jun 10, 2024
+60
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
inspector
Issues and PRs related to the V8 inspector protocol
needs-ci
PRs that need a full CI run.
labels
Jun 8, 2024
theanarkh
force-pushed
the
fix_permission_inspector_crash
branch
from
June 8, 2024 18:36
9e5e24a
to
7573b6b
Compare
anonrig
approved these changes
Jun 8, 2024
cc @eugeneo |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 9, 2024
RafaelGSS
approved these changes
Jun 9, 2024
eugeneo
approved these changes
Jun 9, 2024
Interesting. I see a crash locally (but I did not debug it):
```
$ node --experimental-permission --inspect-brk --eval "console.log('Hi')"
Segmentation fault
```
I wonder if this is the same or a different issue.
…On Sat, Jun 8, 2024 at 8:50 PM theanarkh ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/parallel/test-permission-inspector-brk.js
<#53389 (comment)>:
> +const common = require('../common');
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+const fixtures = require('../common/fixtures');
+const file = fixtures.path('permission', 'inspector-brk.js');
+
+common.skipIfWorker();
+common.skipIfInspectorDisabled();
+
+const { status, stderr } = spawnSync(
+ process.execPath,
+ [
+ '--experimental-permission',
+ '--allow-fs-read=*',
+ '--inspect-brk',
+ file,
It seems the process does not crash when using --eval because the crash
is caused by this
<https://github.com/nodejs/node/blob/main/lib/internal/modules/cjs/loader.js#L1425>
code.
—
Reply to this email directly, view it on GitHub
<#53389 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACGJLJPMQ4N4X2XFELQLS3ZGPGHBAVCNFSM6AAAAABJAF5ZIWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBWGA3DCNJZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I will add permission check in node_contextify.cc to fix this(Node.js will run into EvaluateMachine of node_contextify.cc when setting --eval flag). |
MoLow
reviewed
Jun 9, 2024
MoLow
approved these changes
Jun 9, 2024
theanarkh
force-pushed
the
fix_permission_inspector_crash
branch
4 times, most recently
from
June 9, 2024 17:59
4a8cf55
to
ac0f283
Compare
theanarkh
force-pushed
the
fix_permission_inspector_crash
branch
from
June 9, 2024 18:00
ac0f283
to
5fee021
Compare
cola119
approved these changes
Jun 10, 2024
cola119
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jun 10, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 10, 2024
H4ad
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 10, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 10, 2024
Landed in 430c026 |
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53389 Fixes: nodejs#53385 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53389 Fixes: nodejs#53385 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
inspector
Issues and PRs related to the V8 inspector protocol
needs-ci
PRs that need a full CI run.
permission
Issues and PRs related to the Permission Model
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #53385
make -j4 test
(UNIX), orvcbuild test
(Windows) passes