Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase timeouts on some unref timers tests #5352

Closed
wants to merge 0 commits into from
Closed

test: increase timeouts on some unref timers tests #5352

wants to merge 0 commits into from

Conversation

Fishrock123
Copy link
Contributor

Fix: #5351
Refs: #4561
PR-URL: #5352

After #4007 lands we should consider replacing some of these tests with refed versions since they will take the same codepath.

Or add something where we can tell it to just use refed handles.

@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Feb 21, 2016
@Fishrock123 Fishrock123 force-pushed the increase-unref-timeouts branch from fdcabf4 to 40a93ad Compare February 21, 2016 16:10
@Trott
Copy link
Member

Trott commented Feb 21, 2016

LGTM

@mscdex mscdex added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Feb 21, 2016
@jasnell
Copy link
Member

jasnell commented Feb 21, 2016

LGTM

1 similar comment
@JungMinu
Copy link
Member

LGTM

@Fishrock123
Copy link
Contributor Author

guess I should probably run the CI: https://ci.nodejs.org/job/node-test-pull-request/1722/

Fishrock123 added a commit that referenced this pull request Feb 22, 2016
@Fishrock123
test: increase timeouts on some unref timers tests
65cd2a0 
Fix: #5351
Refs: #4561
PR-URL: #5352

Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@Fishrock123 Fishrock123 force-pushed the increase-unref-timeouts branch from 40a93ad to 65cd2a0 Compare February 22, 2016 17:16
@Fishrock123
Copy link
Contributor Author

landed in 65cd2a0

rvagg pushed a commit that referenced this pull request Feb 27, 2016
@Fishrock123 @rvagg
test: increase timeouts on some unref timers tests
0f54553 
Fix: #5351
Refs: #4561
PR-URL: #5352

Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
Merged
5 tasks
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@Fishrock123
test: increase timeouts on some unref timers tests
213e13e 
Fix: #5351
Refs: #4561
PR-URL: #5352

Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@Fishrock123
test: increase timeouts on some unref timers tests
99269ff 
Fix: #5351
Refs: #4561
PR-URL: #5352

Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Fishrock123 @Trott @jasnell @JungMinu @mscdex @MylesBorins