Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x] Revert "deps: update undici to 6.13.0" #53520

Closed
wants to merge 3 commits into from
Closed

[v20.x] Revert "deps: update undici to 6.13.0" #53520

wants to merge 3 commits into from

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Jun 20, 2024 •
edited by richardlau
Loading

Refs: #53186
Refs: nodejs/undici#3267
Refs: #53486
Reverts undici to v6.6.2
cc @mcollina

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 20, 2024 •
edited by marco-ippolito
Loading

Review requested:

  • @nodejs/security-wg
  • @nodejs/undici

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Jun 20, 2024
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2024
mcollina
mcollina requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a no go. This has the following vulns:

GHSA-m4v8-wqvr-p9f7
GHSA-9qxr-qj54-h672
GHSA-3787-6prv-h9w3

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59904/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marco-ippolito @nodejs-github-bot @mcollina @richardlau