Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: lock versions of irrelevant DB deps #53546

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

targos
Copy link
Member

@targos targos commented Jun 22, 2024

caniuse-lite and electron-to-chromium are "database dependencies"
that we don't care about and are often updated, increasing the size of
the repository each time. Lock their versions to the currently
installed one so it doesn't happen in the future.

`caniuse-lite` and `electron-to-chromium` are "database dependencies"
that we don't care about and are often updated, increasing the size of
the repository each time. Lock their versions to the currently
installed one so it doesn't happen in the future.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 22, 2024
@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 23, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 24, 2024
@nodejs-github-bot nodejs-github-bot merged commit e0e0b1a into nodejs:main Jun 24, 2024
28 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e0e0b1a

@targos targos deleted the lock-db branch June 24, 2024 14:02
targos added a commit that referenced this pull request Jun 25, 2024
`caniuse-lite` and `electron-to-chromium` are "database dependencies"
that we don't care about and are often updated, increasing the size of
the repository each time. Lock their versions to the currently
installed one so it doesn't happen in the future.

PR-URL: #53546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos added a commit that referenced this pull request Jun 25, 2024
`caniuse-lite` and `electron-to-chromium` are "database dependencies"
that we don't care about and are often updated, increasing the size of
the repository each time. Lock their versions to the currently
installed one so it doesn't happen in the future.

PR-URL: #53546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants