Added OpenSSL Security Level section to docs/api/tls.md #53647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
RedYetiDev
reviewed
Jul 1, 2024
pimterry
requested changes
Jul 3, 2024
There was a problem hiding this comment.
Echoing the couple of last small tweaks from @RedYetiDev, but once those are resolved this all looks good to me. Thanks for putting this together @afanasy, looks great & it'll be super helpful for others trying to use old TLS settings.
|
Also, the commit message of the first commit should begin with the change category/subsystem, and then the commit message starting with a present-tense verb. For example, |
|
@RedYetiDev @pimterry Thank you so much for the prompt review! I've made the changes you've mentioned and force-pushed to update the commit message. |
pimterry
approved these changes
Jul 10, 2024
pimterry
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 059f2f4 |
aduh95
pushed a commit
that referenced
this pull request
Jul 12, 2024
PR-URL: #53647 Reviewed-By: Tim Perry <pimterry@gmail.com>
Merged
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
PR-URL: #53647 Reviewed-By: Tim Perry <pimterry@gmail.com>
ehsankhfr
pushed a commit
to ehsankhfr/node
that referenced
this pull request
Jul 18, 2024
PR-URL: nodejs#53647 Reviewed-By: Tim Perry <pimterry@gmail.com>
marco-ippolito
added
the
backport-requested-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pimterry Docs update as discussed #49236.