Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mention prototype check in deepStrictEqual() #5367

Closed
wants to merge 1 commit into from
Closed

doc: mention prototype check in deepStrictEqual() #5367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api/assert.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,9 @@ parameter is undefined, a default error message is assigned.

## assert.deepStrictEqual(actual, expected[, message])

Generally identical to [`assert.deepEqual()`][] with the exception that primitive
values are compared using the strict equality operator ( `===` ).
Generally identical to [`assert.deepEqual()`][] with the exceptions that
primitive values are compared using the strict equality operator ( `===` ), and
object prototypes are included in the comparison.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

object prototypes are included in the comparison.

seems a little vague to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See proposed change in the main thread.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would have been better if we could somehow say that prototypes should be the same. But yeah the proposed change also is okay.


```js
const assert = require('assert');
Expand Down