Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update wpt test for url #53814

Merged
merged 1 commit into from
Jul 14, 2024
Merged

test: update wpt test for url #53814

merged 1 commit into from
Jul 14, 2024

Conversation

mertcanaltin
Copy link
Member

Updating Web Platform Tests

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 11, 2024
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 11, 2024
@anonrig
Copy link
Member

anonrig commented Jul 11, 2024

Ada already covers these tests. It's good that we're updating it on Node.js as well.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 11, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60248/

@anonrig anonrig changed the title test: update wpt test test: update wpt test for url Jul 11, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60258/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60280/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60307/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 14, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 14, 2024
@nodejs-github-bot nodejs-github-bot merged commit e44ec42 into nodejs:main Jul 14, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e44ec42

aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@mertcanaltin @aduh95
test: update wpt test
53a7dd7 
PR-URL: #53814
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Jul 16, 2024
Merged
ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
@mertcanaltin @ehsankhfr
test: update wpt test
9a01daa 
PR-URL: nodejs#53814
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 21, 2024
@mertcanaltin @targos
test: update wpt test
931ff43 
PR-URL: #53814
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mertcanaltin @nodejs-github-bot @anonrig @panva @lpinca