Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: switch from ToLocalChecked to ToLocal in node_webstorage #53959

Merged
merged 1 commit into from
Jul 21, 2024
Merged

src: switch from ToLocalChecked to ToLocal in node_webstorage #53959

merged 1 commit into from
Jul 21, 2024
+69 −29

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 19, 2024

No description provided.

@jasnell jasnell requested review from anonrig and cjihrig July 19, 2024 22:03
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 19, 2024
@jasnell jasnell force-pushed the fixup-node-webstorage-tolocalchecked branch from 531fe5a to 66d9d0d Compare July 19, 2024 22:08
juanarbol
juanarbol approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I saw something like this a couple weeks ago… r u fuzzing Node?

@jasnell jasnell force-pushed the fixup-node-webstorage-tolocalchecked branch from 66d9d0d to 795c8a4 Compare July 21, 2024 02:29
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 21, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/60498/ 💚

@jasnell jasnell added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jul 21, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 21, 2024
@nodejs-github-bot nodejs-github-bot merged commit eb85db4 into nodejs:main Jul 21, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in eb85db4

targos pushed a commit that referenced this pull request Jul 28, 2024
@jasnell @targos
src: switch from ToLocalChecked to ToLocal in node_webstorage
75c7e70 
PR-URL: #53959
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@jasnell @RafaelGSS
src: switch from ToLocalChecked to ToLocal in node_webstorage
fbf74bc 
PR-URL: #53959
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @anonrig @cjihrig @juanarbol @targos