Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add content for Blob.bytes() #54121

Closed
wants to merge 2 commits into from
Closed

doc: add content for Blob.bytes() #54121

wants to merge 2 commits into from

Conversation

sendoru
Copy link
Contributor

@sendoru sendoru commented Jul 30, 2024 •
edited
Loading

This fixes #54105, and adds missing docstring for Blob.bytes() as well.

sendoru added 2 commits July 30, 2024 19:32
@sendoru
doc: add content for Blob.bytes()
9ef0086 
Fixes: nodejs#54105
Refs: nodejs#53221
@sendoru
buffer: add docstring for Blob.bytes()
1a12d83 
Add docstring that clarifies the return type of Blob.bytes()
(`Promise<Uint8Array>`)

Refs: nodejs#53221
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 30, 2024
@jakecastelli
Copy link
Member

Thanks for your contribution, there are two PRs (first + second) that have already opened to fix the issue and they are slightly earlier than yours 😞 would you mind reviewing them instead? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blob.bytes() not documented
3 participants
@sendoru @jakecastelli @nodejs-github-bot