-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: increase timeout for test-tls-fast-writing #5466
Conversation
Factor 10 seems a bit much, no? Do CI machines do multiple runs in parallel? |
@silverwind asked:
There's no real advantage to "right-sizing" the timeout other than a user waits a second or two less on a failed test at the command line. So I'd rather put in a preposterous increase now and never have to deal with the problem again instead of putting in a modest increase now and needing to put in another modest increase or two in a month.
I don't think they do yet but I believe @jbergstroem is not far from having that implemented. (Or was the switch already flipped on that?) |
@Trott still not implemented. |
@silverwind If reducing the increase from a factor of 10 to a factor of (say) 2 would make you more comfortable with the change, I'm totally OK with doing that instead. |
My issue is that these tests usually set a performance goal through these timeouts, I think I'd be okay with something more modest like 2x or 3x. |
Increase timeout for test from 500ms to 1000ms so busy slow machines don't produce false positives. Fixes: nodejs#4964
9d71427
to
829339c
Compare
@silverwind OK, changed to 1000ms instead of 5000ms. |
CI is green except for one host that failed to finish building. Looks good to anyone? @nodejs/testing |
LGTM |
Increase timeout for test from 500ms to 1000ms so busy slow machines don't produce false positives. Fixes: nodejs#4964 PR-URL: nodejs#5466 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Landed in c133d07 |
Increase timeout for test from 500ms to 5000ms so busy slow machines
don't produce false positives.
Fixes: #4964