doc: fix crypto update() signatures #5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
crypto
Closed
|
@mscdex Does |
mscdex
force-pushed
the
doc-crypto-fix-hmac-update-signature
branch
2 times, most recently
from
8de1720
to
92a60fd
Compare
|
@shigeki Fixed. |
mscdex
changed the title
|
Thanks. LGTM. |
|
As the originator of #5499, I have to say that the most misleading part of the doc is near the top of the page where it states
Once I saw that it should be OpenSSL compatible, it was easy to prove that it isn't. I don't know of a way to arrive at the same digest that node does using OpenSSL when multibyte characters are in the digest stream (which is probably just ignorance on my part). My real problem now is that other systems (e.g., JDK) digest the same as OpenSSL (there is no such thing as |
PR-URL: nodejs#5500 Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
mscdex
force-pushed
the
doc-crypto-fix-hmac-update-signature
branch
from
92a60fd
to
af09a9c
Compare
Fishrock123
pushed a commit
that referenced
this pull request
Mar 22, 2016
PR-URL: #5500 Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
|
@mscdex should this go to lts? |
|
Probably, I think the API has been this way at least since v0.10 IIRC. |
|
+1 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
PR-URL: #5500 Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
PR-URL: #5500 Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jul 19, 2016
The default encoding for crypto methods was changed in v6.0.0, with v4.x keeping a default of `binary`. Ref: nodejs#5500 Fixes: nodejs#7712
|
This should not be landed in LTS v4. |
lmoe
pushed a commit
to lmoe/node
that referenced
this pull request
Feb 16, 2017
PullRequest nodejs#5522 and nodejs#5500 described the change of the default encoding into UTF8 in crypto functions. This however was only changed for the non-streaming API. The streaming API still used binary as the default encoding. This commit will change the default streaming API encoding to UTF8 to make both APIs behave the same. It will also add tests to validate the behavior.
addaleax
pushed a commit
that referenced
this pull request
Mar 11, 2017
PullRequest #5522 and #5500 described the change of the default encoding into UTF8 in crypto functions. This however was only changed for the non-streaming API. The streaming API still used binary as the default encoding. This commit will change the default streaming API encoding to UTF8 to make both APIs behave the same. It will also add tests to validate the behavior. Refs: #5522 Refs: #5500 PR-URL: #8611 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
PullRequest nodejs#5522 and nodejs#5500 described the change of the default encoding into UTF8 in crypto functions. This however was only changed for the non-streaming API. The streaming API still used binary as the default encoding. This commit will change the default streaming API encoding to UTF8 to make both APIs behave the same. It will also add tests to validate the behavior. Refs: nodejs#5522 Refs: nodejs#5500 PR-URL: nodejs#8611 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
Description of change
Fixes: #5499