-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: deflake test-inspector-strip-types #55058
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
lpinca:deflake/test-inspector-strip-types
Sep 24, 2024
Merged
test: deflake test-inspector-strip-types #55058
nodejs-github-bot
merged 1 commit into
nodejs:main
from
lpinca:deflake/test-inspector-strip-types
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `NodeRuntime.waitingForDebugger` event. Refs: nodejs#51560
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Sep 22, 2024
Before:
After:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55058 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 652 652
Lines 183912 183912
Branches 35865 35868 +3
=======================================
+ Hits 162272 162275 +3
Misses 14915 14915
+ Partials 6725 6722 -3 |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 22, 2024
aduh95
approved these changes
Sep 22, 2024
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 22, 2024
atlowChemi
approved these changes
Sep 22, 2024
legendecas
approved these changes
Sep 23, 2024
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 23, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 24, 2024
Landed in 3c5ceff |
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Use the `NodeRuntime.waitingForDebugger` event. Refs: nodejs#51560 PR-URL: nodejs#55058 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
Nov 16, 2024
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Use the `NodeRuntime.waitingForDebugger` event. Refs: nodejs#51560 PR-URL: nodejs#55058 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
NodeRuntime.waitingForDebugger
event.Refs: #51560