Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: close and flush destinations on forced exit #55099

Merged
merged 1 commit into from
Sep 28, 2024
Merged

test_runner: close and flush destinations on forced exit #55099

merged 1 commit into from
Sep 28, 2024

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 24, 2024

This commit updates the test runner to explicitly close and flush all destination file streams when the --test-force-exit flag is used.

Fixes: #54327

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 24, 2024
@RedYetiDev
Copy link
Member

Thanks for tackling this! FWIW LGTM

@cjihrig
test_runner: close and flush destinations on forced exit
d170b87 
This commit updates the test runner to explicitly close and flush
all destination file streams when the --test-force-exit flag is
used.

Fixes: nodejs#54327
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (ffe0dc5) to head (d170b87).
Report is 401 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55099      +/-   ##
==========================================
- Coverage   88.24%   88.24%   -0.01%     
==========================================
  Files         651      651              
  Lines      183877   183898      +21     
  Branches    35853    35858       +5     
==========================================
+ Hits       162269   162282      +13     
- Misses      14899    14903       +4     
- Partials     6709     6713       +4
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 96.97% <100.00%> (+0.04%) ⬆️
lib/internal/test_runner/utils.js 56.27% <100.00%> (+0.38%) ⬆️

... and 20 files with indirect coverage changes

@RedYetiDev RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62745/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2024 •
edited by jakecastelli
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/62766/ 💛

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit e32521a into nodejs:main Sep 28, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e32521a

@cjihrig cjihrig deleted the force-exit branch September 28, 2024 15:31
targos pushed a commit that referenced this pull request Oct 4, 2024
@cjihrig @targos
test_runner: close and flush destinations on forced exit
d3240c5 
This commit updates the test runner to explicitly close and flush
all destination file streams when the --test-force-exit flag is
used.

Fixes: #54327
PR-URL: #55099
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
targos pushed a commit that referenced this pull request Oct 4, 2024
@cjihrig @targos
test_runner: close and flush destinations on forced exit
19cfa31 
This commit updates the test runner to explicitly close and flush
all destination file streams when the --test-force-exit flag is
used.

Fixes: #54327
PR-URL: #55099
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@cjihrig @louwers
test_runner: close and flush destinations on forced exit
40c01a3 
This commit updates the test runner to explicitly close and flush
all destination file streams when the --test-force-exit flag is
used.

Fixes: nodejs#54327
PR-URL: nodejs#55099
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@cjihrig @tpoisseau
test_runner: close and flush destinations on forced exit
c04c407 
This commit updates the test runner to explicitly close and flush
all destination file streams when the --test-force-exit flag is
used.

Fixes: nodejs#54327
PR-URL: nodejs#55099
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedYetiDev RedYetiDev RedYetiDev left review comments

@atlowChemi atlowChemi atlowChemi approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test runner with junit reporter and forceExit flag results in incomplete report
7 participants
@cjihrig @nodejs-github-bot @RedYetiDev @jakecastelli @atlowChemi @aduh95 @marco-ippolito