src: migrate String::Value to String::ValueView
#55458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
RedYetiDev
force-pushed
the
v8-string--value-deprecate
branch
from
67d7fcd
to
fdc94c9
Compare
RedYetiDev
added
needs-citgm
|
I've added
needs-benchmark-ci
I've also added
needs-citgm
|
RedYetiDev
changed the title
String::Value to String::ValueViewString::Value to String::ValueView
anonrig
reviewed
Oct 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55458 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 653 653
Lines 187485 187429 -56
Branches 36095 36070 -25
=======================================
- Hits 165764 165717 -47
+ Misses 14966 14950 -16
- Partials 6755 6762 +7
|
vmoroz
reviewed
Oct 19, 2024
vmoroz
reviewed
Oct 19, 2024
vmoroz
reviewed
Oct 19, 2024
RedYetiDev
added
request-ci
|
I'm gonna hold off on a CI until the GitHub builds pass, because there might be failures that are already evident |
anonrig
approved these changes
Oct 19, 2024
RedYetiDev
added
author ready
github-actions
bot
removed
the
request-ci
Please don't do that, the label is there to inform the bot this PR requires passing Jenkins CI to land
What benchmark would we run? |
That was an accident 😅, I don't even remember doing that.
I was thinking Buffer (for the indexOf), and string_bytes (if we have one) |
|
CITGM ( |
|
Results: All failures appear to be not related to this change, most are |
|
Can someone start a benchmark CI, or remove the label if you don't think it's needed? |
anonrig
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55458 ✔ Done loading data for nodejs/node/pull/55458 ----------------------------------- PR info ------------------------------------ Title src: migrate `String::Value` to `String::ValueView` (#55458) Author Aviv Keller <redyetidev@gmail.com> (@RedYetiDev) Branch RedYetiDev:v8-string--value-deprecate -> nodejs:main Labels c++, lib / src, author ready, needs-ci, needs-citgm, commit-queue-squash Commits 5 - src: migrate `String::Value` to `String::ValueView` - fixup! src: migrate `String::Value` to `String::ValueView` - fixup! fixup! src: migrate `String::Value` to `String::ValueView` - fixup! fixup! fixup! src: migrate `String::Value` to `String::ValueView` - fixup! fixup! fixup! fixup! src: migrate `String::Value` to `String::… Committers 1 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/55458 Refs: https://github.com/nodejs/node/issues/55452 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55458 Refs: https://github.com/nodejs/node/issues/55452 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - fixup! fixup! fixup! fixup! src: migrate `String::Value` to `String::… ℹ This PR was created on Sat, 19 Oct 2024 16:27:52 GMT ✔ Approvals: 3 ✔ - Vladimir Morozov (@vmoroz): https://github.com/nodejs/node/pull/55458#pullrequestreview-2379682983 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/55458#pullrequestreview-2379711729 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55458#pullrequestreview-2380689360 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-19T20:50:38Z: https://ci.nodejs.org/job/node-test-pull-request/63206/ ℹ Last CITGM CI on 2024-10-24T21:10:17Z: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3493/ - Querying data for job/node-test-pull-request/3493/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11543590208 |
RedYetiDev
removed
the
commit-queue-failed
|
This needs an approval after the most recent change to land |
anonrig
approved these changes
Oct 29, 2024
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 45c6a9e |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Oct 30, 2024
Fixes nodejs#54417 Ref: nodejs#55452 PR-URL: nodejs#55458 Refs: nodejs#55452 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2024
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Fixes nodejs#54417 Ref: nodejs#55452 PR-URL: nodejs#55458 Refs: nodejs#55452 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added
dont-land-on-v18.x
|
PR is being reverted because of #55826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54417
Ref: #55452
v8::String::Valueis deprecated, so this PR replaces it withv8::String::ValueView