assert: fix the string length check for printing the simple diff

[puskin94]

Fixes a small issue introduced in #54862

The check that was comparing the total string length to decide if the comparison was long enough to pick between the "stacked" diff or the "simple" one, was not considering the double quotes surrounding actual and expected when they are strings

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (b0ffe9e) to head (228cc94).
Report is 89 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55474      +/-   ##
==========================================
- Coverage   88.42%   88.42%   -0.01%     
==========================================
  Files         653      653              
  Lines      187498   187422      -76     
  Branches    36100    36072      -28     
==========================================
- Hits       165791   165721      -70     
+ Misses      14957    14950       -7     
- Partials     6750     6751       +1     

Files with missing lines	Coverage Δ
lib/internal/assert/assertion_error.js	95.22% <100.00%> (+0.08%)	⬆️

... and 42 files with indirect coverage changes

[RedYetiDev]

Hi! Please mark the PRas draft if it's not ready to be reviewed, thank way, it'll be easier for reviewers to peruse the issue tracker

[puskin94]

Hi! Please mark the PRas draft if it's not ready to be reviewed, thank way, it'll be easier for reviewers to peruse the issue tracker

Yes, yesterday when I pushed I was running aroung in between flights, it was hard for me to handle github on the phone :)

You can remove the wip label now!

[pmarchini]

Hey @puskin94, I think we should also add some tests related to the difference in behavior between "colored" and "non-colored" diff.
There's a PR that is partially related: #55404, I would suggest waiting for it to land before adding the tests, as the Myers diff leverages colors.hasColors (if I'm not mistaken)

[puskin94]

@pmarchini that MR has been merged but didn't improve the colored output in assertion related checks

[pmarchini]

@pmarchini that MR has been merged but didn't improve the colored output in assertion related checks

Hey @puskin94, could you please create a draft PR containing some tests to highlight the unexpected behaviors?
The PR itself changed the way hasColors works.
Before the PR, many cases were just not using colors even when expected, which probably made some issues evident, or at least I would say so.
The fact that no tests broke following the changes also highlights that we need to cover that specific subset of use cases.
Would you like to try investigating the issue? 😬

[pmarchini]

LGTM

[pmarchini]

FYI @nodejs/assert @nodejs/test_runner

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63319/

[nodejs-github-bot]

Landed in 10cce65