test: avoid apply() calls with large amount of elements
#55501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55501 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 653 653
Lines 187437 187476 +39
Branches 36079 36085 +6
=======================================
+ Hits 165732 165770 +38
- Misses 14950 14951 +1
Partials 6755 6755 |
lpinca
approved these changes
Oct 23, 2024
github-actions
bot
removed
the
request-ci
LiviaMedeiros
added
the
author ready
aduh95
approved these changes
Oct 26, 2024
atlowChemi
approved these changes
Oct 26, 2024
atlowChemi
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5e27e59 |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2024
PR-URL: #55501 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55501 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are segfaulting in
ulimit -s 512environment.