test: test_runner#mock:timers housekeeping/refactoring #55506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
badkeyy
force-pushed
the
improvement/mock-timers-test-refactor
branch
from
cd6b3be
to
e0cbc87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55506 +/- ##
==========================================
- Coverage 88.42% 88.41% -0.01%
==========================================
Files 653 654 +1
Lines 187498 187552 +54
Branches 36100 36084 -16
==========================================
+ Hits 165791 165833 +42
+ Misses 14957 14955 -2
- Partials 6750 6764 +14 |
RedYetiDev
reviewed
Oct 24, 2024
ErickWendel
approved these changes
Oct 24, 2024
atlowChemi
approved these changes
Oct 26, 2024
ovflowd
added
commit-queue
ovflowd
approved these changes
Oct 28, 2024
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55506 ✔ Done loading data for nodejs/node/pull/55506 ----------------------------------- PR info ------------------------------------ Title test: test_runner#mock:timers housekeeping/refactoring (#55506) Author Julian Gassner <julian@gassner.online> (@badkeyy) Branch badkeyy:improvement/mock-timers-test-refactor -> nodejs:main Labels test, needs-ci, commit-queue-squash Commits 3 - test: split up test-runner-mock-timers test - test: use timeout_max value for timer mocking test instead of hardcod… - test: removed double describe Committers 1 - Julian Gassner <julian.gassner@tum.de> PR-URL: https://github.com/nodejs/node/pull/55506 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55506 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 23 Oct 2024 20:25:14 GMT ✔ Approvals: 3 ✔ - Erick Wendel (@ErickWendel): https://github.com/nodejs/node/pull/55506#pullrequestreview-2393008154 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/55506#pullrequestreview-2397352614 ✔ - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/55506#pullrequestreview-2400008659 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11561209244 |
|
Ah didn't see Jenkins didn't run yet. Just triggered it. |
ovflowd
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6dea41d |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Oct 30, 2024
PR-URL: nodejs#55506 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2024
PR-URL: #55506 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55506 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup and refactoring of test-runner-mock-timers (as mentioned in #55375 (review)):
Modularized test-runner-mock-timers: Split the existing file into three logically distinct parts:
- test-runner-mock-timers
- test-runner-mock-timers-scheduler
- test-runner-mock-timers-date
Replaced hardcoded max timeout values: Removed hardcoded max timeout values in test-runner-mock-timers and replaced them with the max timeout value exposed in internal/timers. The
--expose-internalsflag was added to test-runner-mock-timers for this purpose.