Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix GN build for sqlite and nghttp2 #55529

Merged
merged 1 commit into from
Oct 27, 2024
Merged

build: fix GN build for sqlite and nghttp2 #55529

merged 1 commit into from
Oct 27, 2024

Conversation

codebytere
Copy link
Member

As in title - fixes build failures resultant of recent updates to sqlite and nghttp2.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Oct 25, 2024
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63300/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit c35cbcd into nodejs:main Oct 27, 2024
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c35cbcd

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2024
@codebytere @RafaelGSS
build: fix GN build for sqlite and nghttp2
bb78904 
PR-URL: #55529
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Cheng Zhao <zcbenz@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@codebytere @louwers
build: fix GN build for sqlite and nghttp2
cb20aa5 
PR-URL: nodejs#55529
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Cheng Zhao <zcbenz@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@codebytere @nodejs-github-bot @zcbenz @lpinca @anonrig @cjihrig @atlowChemi