Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do not run IsWindowsBatchFile on non-windows #55560

Merged
merged 1 commit into from
Oct 29, 2024
Merged

src: do not run IsWindowsBatchFile on non-windows #55560

merged 1 commit into from
Oct 29, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 27, 2024

Let's not run IsWindowsBatchFile on non-windows environments.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 27, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (5e27e59) to head (8fdd36e).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55560   +/-   ##
=======================================
  Coverage   88.42%   88.43%           
=======================================
  Files         654      654           
  Lines      187662   187656    -6     
  Branches    36121    36121           
=======================================
+ Hits       165939   165949   +10     
+ Misses      14962    14951   -11     
+ Partials     6761     6756    -5
Files with missing lines Coverage Δ
src/process_wrap.cc 84.32% <ø> (+0.90%) ⬆️
src/spawn_sync.cc 77.46% <ø> (+0.23%) ⬆️
src/util-inl.h 83.85% <ø> (-0.13%) ⬇️

... and 18 files with indirect coverage changes

richardlau
richardlau approved these changes Oct 27, 2024
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd include the comment inside the #ifdef but that's my own preference and not a blocker.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63315/

@bnoordhuis
Copy link
Member

I specifically wrote it that way so that IsWindowsBatchFile and its call sites get type-checked by the compiler always and everywhere. Of course the function was still small and nimble back then.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63316/

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 27, 2024
StefanStojanovic
StefanStojanovic approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit e160e54 into nodejs:main Oct 29, 2024
76 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e160e54

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Oct 30, 2024
@anonrig @Ceres6
src: do not run IsWindowsBatchFile on non-windows
ea2a592 
PR-URL: nodejs#55560
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2024
@anonrig @RafaelGSS
src: do not run IsWindowsBatchFile on non-windows
016baae 
PR-URL: #55560
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@anonrig @louwers
src: do not run IsWindowsBatchFile on non-windows
827a4a6 
PR-URL: nodejs#55560
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@aduh95 aduh95 mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anonrig @nodejs-github-bot @bnoordhuis @richardlau @StefanStojanovic