node-api: allow napi_delete_reference in basic finalizers #55620
+71
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`napi_delete_reference` must be called immediately for a `napi_reference` returned from `napi_wrap` in the corresponding finalizer, in order to clean up the `napi_reference` timely. `napi_delete_reference` is safe to be invoked during GC.
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55620 +/- ##
==========================================
- Coverage 88.43% 87.96% -0.47%
==========================================
Files 654 656 +2
Lines 187666 188384 +718
Branches 36119 35968 -151
==========================================
- Hits 165954 165716 -238
- Misses 14954 15838 +884
- Partials 6758 6830 +72
|
github-actions
bot
removed
the
request-ci
|
@vmoroz will confirm that there is no issue in a Hermes implementation. Main concern is around if deleting the reference and making an object collectable could cause some issues, for example if an engine uses reference counting and would try to collect the object immediately. |
|
We discussed in the team meeting today and @vmoroz confirmed he looked at the Hermes code and its not a concern from the Hermes perspective. |
gabrielschulhof
approved these changes
Dec 6, 2024
mhdawson
added
the
commit-queue-squash
jasnell
approved these changes
Dec 11, 2024
vmoroz
approved these changes
Dec 11, 2024
github-actions
bot
removed
the
request-ci
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6f084ff |
targos
pushed a commit
that referenced
this pull request
Dec 13, 2024
`napi_delete_reference` must be called immediately for a `napi_reference` returned from `napi_wrap` in the corresponding finalizer, in order to clean up the `napi_reference` timely. `napi_delete_reference` is safe to be invoked during GC. PR-URL: #55620 Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
`napi_delete_reference` must be called immediately for a `napi_reference` returned from `napi_wrap` in the corresponding finalizer, in order to clean up the `napi_reference` timely. `napi_delete_reference` is safe to be invoked during GC. PR-URL: #55620 Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
napi_delete_referencemust be called immediately for anapi_referencereturned fromnapi_wrapin the correspondingfinalizer, in order to clean up the
napi_referencetimely.napi_delete_referenceis safe to be invoked during GC.