-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: add diagnostic channel http.server.response.created
#55622
http: add diagnostic channel http.server.response.created
#55622
Conversation
Review requested:
|
http.server.response.created
eb4e926
to
1265dba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
(We would need similar PRs for http2 too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55622 +/- ##
=======================================
Coverage 88.43% 88.43%
=======================================
Files 654 654
Lines 187718 187725 +7
Branches 36129 36129
=======================================
+ Hits 166010 166018 +8
- Misses 14948 14953 +5
+ Partials 6760 6754 -6
|
Landed in 560b2a1 |
PR-URL: nodejs#55622 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #55622 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Followup of #55586