doc: add esm examples to node:timers
#55857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
lpinca
approved these changes
Nov 14, 2024
aduh95
reviewed
Nov 14, 2024
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
reviewed
Nov 18, 2024
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
@aduh95 I think the tests throw because I triggered a run before another process had ended, can you re-run them? 😁 🙏 |
jazelly
approved these changes
Nov 20, 2024
jazelly
added
author ready
aduh95
approved these changes
Nov 20, 2024
|
My bad, didn't mean to "request-ci". |
jazelly
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d894772 |
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55857 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55857 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
PR-URL: #55857 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 10, 2024
PR-URL: #55857 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two examples for Cancelling timers in the Timers docs are missing their
ESMcounterparts.This PR adds them.
Best regards 🫶
Edit: With this change all current
node:timersexamples would have theirESMcounterparts, there are no more left