Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: use tokenless Codecov uploads #55943

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

targos
Copy link
Member

@targos targos commented Nov 21, 2024

Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token

I already enabled it in the Codecov settings for the nodejs org.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.99%. Comparing base (e92499c) to head (22f5f49).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55943      +/-   ##
==========================================
- Coverage   87.99%   87.99%   -0.01%     
==========================================
  Files         653      653              
  Lines      188091   188091              
  Branches    35941    35947       +6     
==========================================
- Hits       165516   165515       -1     
+ Misses      15751    15742       -9     
- Partials     6824     6834      +10     

see 26 files with indirect coverage changes

---- 🚨 Try these New Features:

@targos
Copy link
Member Author

targos commented Nov 24, 2024

Rebased to reset the coverage-windows status (workflow is currently broken and has been disabled).

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit ce346b6 into main Nov 25, 2024
18 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ce346b6

@nodejs-github-bot nodejs-github-bot deleted the codecov-tokenless branch November 25, 2024 08:27
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token
PR-URL: nodejs#55943
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token
PR-URL: #55943
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token
PR-URL: #55943
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token
PR-URL: #55943
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token
PR-URL: #55943
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants