Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: more work on quic #55986

Closed
wants to merge 4 commits into from
Closed

quic: more work on quic #55986

wants to merge 4 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 24, 2024

Builds on #55971 which should land first. (this PR includes those commits currently)

Further implementation and refinement of the QUIC JS API

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 24, 2024
@jasnell jasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Nov 24, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell force-pushed the get-quic-working-part1 branch from f434bb8 to 8761d63 Compare November 24, 2024 21:17
@codecov Codecov

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 25, 2024
@jasnell
quic: finish up QuicEndpoint
ee5520e 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
quic: work more on QuicSession and QuicStream
b8b821d 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
quic: additional API cleanups
83257d1 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
quic: add more diagnostic channels
93da5d7 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell force-pushed the get-quic-working-part1 branch from 8761d63 to 93da5d7 Compare November 26, 2024 00:24
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63748/

jasnell added a commit that referenced this pull request Nov 28, 2024
@jasnell
quic: update more QUIC implementation
4cf6fab 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #55986
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@jasnell
Copy link
Member Author

jasnell commented Nov 28, 2024

Landed in 4cf6fab

@jasnell jasnell closed this Nov 28, 2024
targos pushed a commit that referenced this pull request Dec 2, 2024
@jasnell @targos
quic: update more QUIC implementation
d09e57b 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #55986
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
github-actions bot pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@jasnell @nodejs-github-bot
quic: update more QUIC implementation
91f0fd8 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#55986
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@jasnell @nodejs-github-bot
quic: update more QUIC implementation
08c9156 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#55986
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@jasnell @nodejs-github-bot
quic: update more QUIC implementation
f5e3d68 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#55986
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@jasnell @nodejs-github-bot
quic: update more QUIC implementation
c699c15 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#55986
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@jasnell @nodejs-github-bot
quic: update more QUIC implementation
d8a05c4 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#55986
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This was referenced Dec 6, 2024
Closed
Closed
Closed
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@jasnell @aduh95
quic: update more QUIC implementation
62db3c2 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #55986
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@jasnell @aduh95
quic: update more QUIC implementation
e2a0d84 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #55986
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@jasnell @aduh95
quic: update more QUIC implementation
899df21 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #55986
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@Qard Qard Qard approved these changes

@mcollina mcollina mcollina approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @mcollina @Qard @anonrig