Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: handle Float16Array in node:v8 serdes #55996

Merged
merged 11 commits into from
Dec 7, 2024
Merged

lib: handle Float16Array in node:v8 serdes #55996

merged 11 commits into from
Dec 7, 2024

Conversation

bartlomieju
Copy link
Contributor

@bartlomieju bartlomieju commented Nov 26, 2024 •
edited by aduh95
Loading

This commit adds support for Float16Array in node:v8 serde APIs.

While Float16Array is not available as a global yet (pending stabilization in V8),
I "reserved" the next available index for serde purposes so other runtimes, like Deno,
that already support Float16Array, can support it in node:v8 serde APIs
in a future compatible way.

Fixes: #55574

@bartlomieju
Copy link
Contributor Author

CC @bnoordhuis @targos

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 26, 2024
cjihrig
cjihrig reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter is failing (make lint-js).

test/parallel/test-http-url.parse-post.js Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (3511c5c) to head (bce30a4).
Report is 82 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55996      +/-   ##
==========================================
+ Coverage   87.95%   88.00%   +0.04%     
==========================================
  Files         656      656              
  Lines      188304   188935     +631     
  Branches    35972    35972              
==========================================
+ Hits       165624   166271     +647     
+ Misses      15853    15833      -20     
- Partials     6827     6831       +4
Files with missing lines Coverage Δ
lib/v8.js 98.66% <100.00%> (+0.01%) ⬆️

... and 62 files with indirect coverage changes

bnoordhuis
bnoordhuis approved these changes Nov 26, 2024
View reviewed changes
test/parallel/test-v8-serdes.js Outdated Show resolved Hide resolved
bartlomieju and others added 2 commits November 26, 2024 20:03
@bartlomieju @bnoordhuis
Update test/parallel/test-v8-serdes.js
5ed61e1 
Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
@bartlomieju
fix eslint
b50cbcd
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63767/

aduh95
aduh95 reviewed Nov 30, 2024
View reviewed changes
lib/v8.js Outdated Show resolved Hide resolved
@bartlomieju bartlomieju requested a review from aduh95 December 3, 2024 03:25
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63844/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63863/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63866/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63922/

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Dec 7, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 7, 2024
@nodejs-github-bot nodejs-github-bot merged commit ac7fea6 into nodejs:main Dec 7, 2024
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ac7fea6

@bartlomieju bartlomieju deleted the v8_serde_float16 branch December 9, 2024 14:45
@bartlomieju bartlomieju mentioned this pull request Dec 9, 2024
Closed
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@bartlomieju @aduh95
lib: handle Float16Array in node:v8 serdes
889094f 
PR-URL: #55996
Fixes: #55574
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig left review comments

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Float16Array not working in node:v8 serde
7 participants
@bartlomieju @nodejs-github-bot @bnoordhuis @cjihrig @aduh95 @LiviaMedeiros @lpinca