Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: allow dispatch of tools.yml from forks #56008

Merged
merged 1 commit into from
Nov 28, 2024
Merged

tools: allow dispatch of tools.yml from forks #56008

merged 1 commit into from
Nov 28, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 26, 2024

It makes sense to skip the cron job on forks, but dispatch can only happen after an action from the fork owner.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 26, 2024
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit b5eb77f into nodejs:main Nov 28, 2024
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b5eb77f

@aduh95 aduh95 deleted the tool-updater-forks branch November 28, 2024 23:54
targos pushed a commit that referenced this pull request Dec 2, 2024
@aduh95 @targos
tools: allow dispatch of tools.yml from forks
d6a6c8a 
PR-URL: #56008
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
@aduh95 @nodejs-github-bot
tools: allow dispatch of tools.yml from forks
19da769 
PR-URL: nodejs#56008
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
@aduh95 @nodejs-github-bot
tools: allow dispatch of tools.yml from forks
628c2b2 
PR-URL: nodejs#56008
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
@aduh95 @nodejs-github-bot
tools: allow dispatch of tools.yml from forks
dc604aa 
PR-URL: nodejs#56008
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
@aduh95 @nodejs-github-bot
tools: allow dispatch of tools.yml from forks
c5e7198 
PR-URL: nodejs#56008
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This was referenced Dec 6, 2024
Closed
Closed
Closed
aduh95 added a commit that referenced this pull request Dec 13, 2024
@aduh95
tools: allow dispatch of tools.yml from forks
29904e5 
PR-URL: #56008
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 added a commit that referenced this pull request Dec 13, 2024
@aduh95
tools: allow dispatch of tools.yml from forks
1a95bbd 
PR-URL: #56008
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 added a commit that referenced this pull request Dec 13, 2024
@aduh95
tools: allow dispatch of tools.yml from forks
fb03b6e 
PR-URL: #56008
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@juanarbol juanarbol juanarbol approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @nodejs-github-bot @targos @richardlau @juanarbol @RafaelGSS @mertcanaltin