net: support blocklist for net.Server #56079

theanarkh · 2024-11-29T16:26:26Z

Support blocklist options for net.Server, which can be used for disabling inbound access to specific IP addresses, IP ranges, or IP subnets.

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2024-11-29T16:26:31Z

Review requested:

@nodejs/net

lib/net.js

codecov · 2024-11-29T18:57:30Z

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.00%. Comparing base (4cf6fab) to head (083967d).
Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/net.js	81.25%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #56079   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files         656      656           
  Lines      188988   189015   +27     
  Branches    35992    35991    -1     
=======================================
+ Hits       166315   166341   +26     
- Misses      15838    15848   +10     
+ Partials     6835     6826    -9

Files with missing lines	Coverage Δ
lib/net.js	`92.81% <81.25%> (-0.08%)`	⬇️

... and 30 files with indirect coverage changes

doc/api/net.md

nodejs-github-bot · 2024-11-30T06:10:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63810/

nodejs-github-bot · 2024-11-30T11:17:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63813/

nodejs-github-bot · 2024-11-30T14:33:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63815/

mcollina

lgtm

targos · 2024-12-01T09:00:27Z

If #56075 lands with blockList, this should too.

theanarkh · 2024-12-01T11:50:25Z

Done !

nodejs-github-bot · 2024-12-01T16:08:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63828/

nodejs-github-bot · 2024-12-01T17:01:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63829/

juanarbol

lgtm

nodejs-github-bot · 2024-12-02T15:21:33Z

Landed in d5d1e80

PR-URL: #56079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: TODO

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119

PR-URL: nodejs#56079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc: * add LJHarb to collaborators (Jordan Harband) #56132 net: * (SEMVER-MINOR) add BlockList.isBlockList(value) (James M Snell) #56078 * (SEMVER-MINOR) support blockList in net.connect (theanarkh) #56075 * (SEMVER-MINOR) support blockList in net.Server (theanarkh) #56079 * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) nodejs#55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) nodejs#56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) nodejs#55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL: #31

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc: * add LJHarb to collaborators (Jordan Harband) #56132 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075 * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076 * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078 * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) nodejs#55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) nodejs#56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) nodejs#55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL: #32

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) nodejs#55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) nodejs#56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) nodejs#55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL: #33

PR-URL: #56079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Nov 29, 2024

theanarkh force-pushed the support_blocklist_in_net_server branch from 0720545 to 4ecdf03 Compare November 29, 2024 16:36

lpinca reviewed Nov 29, 2024

View reviewed changes

lib/net.js Show resolved Hide resolved

lpinca added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 29, 2024

jasnell approved these changes Nov 29, 2024

View reviewed changes

theanarkh force-pushed the support_blocklist_in_net_server branch from 4ecdf03 to 83871b6 Compare November 29, 2024 17:10

lpinca reviewed Nov 29, 2024

View reviewed changes

doc/api/net.md Outdated Show resolved Hide resolved

theanarkh force-pushed the support_blocklist_in_net_server branch 3 times, most recently from a1321f0 to 1bb4c67 Compare November 30, 2024 02:17

theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2024

mcollina approved these changes Nov 30, 2024

View reviewed changes

net: support blocklist for net.Server

083967d

theanarkh force-pushed the support_blocklist_in_net_server branch from 1bb4c67 to 083967d Compare December 1, 2024 11:50

theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2024

juanarbol approved these changes Dec 2, 2024

View reviewed changes

theanarkh added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 2, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2024

nodejs-github-bot merged commit d5d1e80 into nodejs:main Dec 2, 2024
64 checks passed

targos pushed a commit that referenced this pull request Dec 3, 2024

net: support blocklist for net.Server

30d6041

PR-URL: #56079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

nodejs-github-bot mentioned this pull request Dec 3, 2024

2024-12-10, Version 23.4.0 (Current), @targos #56119

Merged

github-actions bot mentioned this pull request Dec 6, 2024

2024-12-11, Version 23.4.0 (Current), @aduh95 aduh95/node#31

Closed

github-actions bot mentioned this pull request Dec 11, 2024

2024-12-12, Version 23.4.0 (Current) aduh95/node#32

Closed

github-actions bot mentioned this pull request Dec 11, 2024

2024-12-12, Version 23.4.0 (Current) aduh95/node#33

Closed

aduh95 pushed a commit that referenced this pull request Dec 13, 2024

net: support blocklist for net.Server

b227216

PR-URL: #56079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

aduh95 pushed a commit that referenced this pull request Dec 13, 2024

net: support blocklist for net.Server

e13584c

PR-URL: #56079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

aduh95 pushed a commit that referenced this pull request Dec 13, 2024

net: support blocklist for net.Server

06ddd62

PR-URL: #56079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: support blocklist for net.Server #56079

net: support blocklist for net.Server #56079

theanarkh commented Nov 29, 2024

nodejs-github-bot commented Nov 29, 2024

codecov bot commented Nov 29, 2024 •

edited

Loading

nodejs-github-bot commented Nov 30, 2024

nodejs-github-bot commented Nov 30, 2024

nodejs-github-bot commented Nov 30, 2024

mcollina left a comment

targos commented Dec 1, 2024

theanarkh commented Dec 1, 2024

nodejs-github-bot commented Dec 1, 2024

nodejs-github-bot commented Dec 1, 2024

juanarbol left a comment

nodejs-github-bot commented Dec 2, 2024

net: support blocklist for net.Server #56079

net: support blocklist for net.Server #56079

Conversation

theanarkh commented Nov 29, 2024

nodejs-github-bot commented Nov 29, 2024

codecov bot commented Nov 29, 2024 • edited Loading

Codecov Report

nodejs-github-bot commented Nov 30, 2024

nodejs-github-bot commented Nov 30, 2024

nodejs-github-bot commented Nov 30, 2024

mcollina left a comment

Choose a reason for hiding this comment

targos commented Dec 1, 2024

theanarkh commented Dec 1, 2024

nodejs-github-bot commented Dec 1, 2024

nodejs-github-bot commented Dec 1, 2024

juanarbol left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Dec 2, 2024

codecov bot commented Nov 29, 2024 •

edited

Loading