Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update WPT for WebCryptoAPI to 3e3374efde #56093

Closed
wants to merge 2 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Dec 1, 2024

This is an automated update of the WPT for WebCryptoAPI to web-platform-tests/wpt@3e3374e.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 1, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.99%. Comparing base (4e44322) to head (99fbcc2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56093      +/-   ##
==========================================
+ Coverage   87.73%   87.99%   +0.25%     
==========================================
  Files         654      656       +2     
  Lines      188523   188958     +435     
  Branches    35795    35978     +183     
==========================================
+ Hits       165399   166267     +868     
+ Misses      16339    15860     -479     
- Partials     6785     6831      +46     

see 53 files with indirect coverage changes

@panva panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2024
@nodejs-github-bot nodejs-github-bot changed the title test: update WPT for WebCryptoAPI to 76dfa54e5d test: update WPT for WebCryptoAPI to 3e3374efde Dec 2, 2024
@panva panva added blocked PRs that are blocked by other issues or PRs. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 2, 2024
@panva

This comment was marked as outdated.

@panva panva removed the blocked PRs that are blocked by other issues or PRs. label Dec 4, 2024
@panva panva force-pushed the actions/update-wpt-WebCryptoAPI branch from 4d9eeba to 99fbcc2 Compare December 4, 2024 11:05
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 4, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/56093
✔  Done loading data for nodejs/node/pull/56093
----------------------------------- PR info ------------------------------------
Title      test: update WPT for WebCryptoAPI to 3e3374efde (#56093)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/update-wpt-WebCryptoAPI -> nodejs:main
Labels     test, author ready, needs-ci
Commits    2
 - test: update WPT for WebCryptoAPI to 76dfa54e5d
 - test: update WPT for WebCryptoAPI to 3e3374efde
Committers 1
 - Filip Skokan <panva.ip@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 01 Dec 2024 00:05:59 GMT
   ✔  Approvals: 3
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/56093#pullrequestreview-2478166105
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/56093#pullrequestreview-2471361879
   ✔  - Jason Zhang (@jazelly): https://github.com/nodejs/node/pull/56093#pullrequestreview-2471407256
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-12-04T13:15:39Z: https://ci.nodejs.org/job/node-test-pull-request/63869/
- Querying data for job/node-test-pull-request/63869/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 56093
From https://github.com/nodejs/node
 * branch                  refs/pull/56093/merge -> FETCH_HEAD
✔  Fetched commits as 4e443224130e..99fbcc2b3a33
--------------------------------------------------------------------------------
[main dbb43004a7] test: update WPT for WebCryptoAPI to 76dfa54e5d
 Date: Sun Dec 1 00:05:57 2024 +0000
 5 files changed, 108 insertions(+), 2 deletions(-)
[main cb31706310] test: update WPT for WebCryptoAPI to 3e3374efde
 Date: Mon Dec 2 10:46:11 2024 +0000
 4 files changed, 46 insertions(+), 26 deletions(-)
 create mode 100644 test/fixtures/wpt/WebCryptoAPI/crypto_key_cached_slots.https.any.js
 delete mode 100644 test/fixtures/wpt/WebCryptoAPI/cryptokey_algorithm_returns_cached_object.https.any.js
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: update WPT for WebCryptoAPI to 76dfa54e5d

PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>

[detached HEAD acf3e19e0c] test: update WPT for WebCryptoAPI to 76dfa54e5d
Date: Sun Dec 1 00:05:57 2024 +0000
5 files changed, 108 insertions(+), 2 deletions(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: update WPT for WebCryptoAPI to 3e3374efde

PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>

[detached HEAD c8b897c82e] test: update WPT for WebCryptoAPI to 3e3374efde
Date: Mon Dec 2 10:46:11 2024 +0000
4 files changed, 46 insertions(+), 26 deletions(-)
create mode 100644 test/fixtures/wpt/WebCryptoAPI/crypto_key_cached_slots.https.any.js
delete mode 100644 test/fixtures/wpt/WebCryptoAPI/cryptokey_algorithm_returns_cached_object.https.any.js
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/12161626379

@panva panva added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 4e44322...09d5be0

nodejs-github-bot added a commit that referenced this pull request Dec 4, 2024
PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
nodejs-github-bot added a commit that referenced this pull request Dec 4, 2024
PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
@panva panva deleted the actions/update-wpt-WebCryptoAPI branch December 5, 2024 09:02
targos pushed a commit that referenced this pull request Dec 6, 2024
PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
targos pushed a commit that referenced this pull request Dec 6, 2024
PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants