tools: use commit title as PR title when creating release proposal #56165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
targos
approved these changes
Dec 7, 2024
marco-ippolito
approved these changes
Dec 7, 2024
aduh95
added
author ready
RafaelGSS
approved these changes
Dec 8, 2024
juanarbol
approved these changes
Dec 9, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 80c0055 |
aduh95
added a commit
that referenced
this pull request
Dec 10, 2024
PR-URL: #56165 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at list of release proposals from before we introduced the automation, we usually used wither the commit title, or the name of the branch, but never the line in the CHANGELOG AFAICT. The difference is that it doesn't contain the GH handle of the releaser (which to me looks weird on a PR title).