lib: remove redundant global RegExps #56182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
targos
approved these changes
Dec 8, 2024
juanarbol
approved these changes
Dec 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56182 +/- ##
==========================================
+ Coverage 88.01% 88.48% +0.47%
==========================================
Files 656 656
Lines 189136 189136
Branches 36004 36317 +313
==========================================
+ Hits 166461 167366 +905
+ Misses 15842 14975 -867
+ Partials 6833 6795 -38
|
anonrig
approved these changes
Dec 8, 2024
LiviaMedeiros
approved these changes
Dec 8, 2024
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Dec 8, 2024
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eef06f7 |
aduh95
pushed a commit
that referenced
this pull request
Dec 10, 2024
PR-URL: #56182 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR that replaces RegExps with
.replaceAllwhen possible