Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: make Maps be partially compared in partialDeepStrictEqual #56195

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

puskin94
Copy link
Contributor

@puskin94 puskin94 commented Dec 9, 2024

Other PR aiming to make the assert.partialDeepStrictEqual function more complete.
Since the introduction of the function in here the Map comparison has been introduced as strict, making examples as the following not possible (e.g. expected is a subset of actual ):

const assert = require('assert');

const actual = new Map([
  ['key1', 'value1'],
  ['key2', 'value2'],
  ['key3', 'value3'],
])

const expected = new Map([
  ['key1', 'value1'],
  ['key2', 'value2'],
])

assert.partialDeepStrictEqual(actual, expected);

This PR makes assert.partialDeepStrictEqual work with partial Map comparisons

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Dec 9, 2024
@BridgeAR BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (3851edf) to head (fa9beaf).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56195   +/-   ##
=======================================
  Coverage   88.49%   88.50%           
=======================================
  Files         656      656           
  Lines      189261   189265    +4     
  Branches    36348    36351    +3     
=======================================
+ Hits       167493   167508   +15     
+ Misses      14977    14966   -11     
  Partials     6791     6791           
Files with missing lines Coverage Δ
lib/assert.js 99.37% <100.00%> (+0.27%) ⬆️

... and 19 files with indirect coverage changes

@puskin94 puskin94 force-pushed the partially-compare-maps branch from 58f4c61 to fa9beaf Compare December 9, 2024 16:41
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 10, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2024
@nodejs-github-bot nodejs-github-bot merged commit 9ec8b9e into nodejs:main Dec 11, 2024
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9ec8b9e

targos pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56195
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants